Repository navigation
Drop BUILD_PREFIX headers from Windows INCLUDE path - #75
Merged
github-actions[bot] merged 3 commits intoMar 7, 2024
Merged
Conversation
Add `cuda-crt-dev*` to `requirements/host` so that compilers can pick up those without needing to alter the Windows include path.
jakirkham
requested review from
bdice,
leofang,
m3vaz,
mmccarty and
vyasr
as code owners
March 7, 2024 08:37
Contributor
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Member
Author
|
@conda-forge-admin, please re-render |
jakirkham
changed the title
BUILD_PREFIX headers from Windows INCLUDE path
This was referenced Mar 7, 2024
Contributor
|
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/cuda-python-feedstock/actions/runs/8185214333. |
jakirkham
added
automerge
Contributor
|
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially address issue ( #74 )
Drop Windows workaround adding headers from the
buildenvironment to the include path. Do this by depending oncuda-crt*headers inrequirements/hostAlso drop call to
setup.pydirectly (re-enabling parallel builds as well)Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)