Repository navigation
All projects to easier override include dirs (use -isystem) - #110
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
-Isystem)-isystem)
robertmaynard
left a comment
There was a problem hiding this comment.
I believe we should only do this for include/cccl as those are marked as system includes by nvcc to support overrides, while the rest of the CUDA toolkit is provided as -I.
I don't think we want different includes taking priority depending on if the input is .cu versus .cpp.
The added paths should be added as `-isystem` to avoid overriding include dirs explicitly set in user build processes. For example some projects vendor CCCL headers and injecting these as `-I` will easily take precedence.
abb6e61 to
b2d0022
Compare
|
Thanks, force-pushed to only apply this for the CCCL paths. |
|
Thanks for reviewing, @robertmaynard! |
|
@seberg, in your opinion, should we also backport this change to CUDA 12.9? |
|
Preferably yes, because CuPy is affected and we want GCC/NVCC to behave correctly in terms of search behavior, in particular on which CCCL copy to use. If this is backported, we can rebuild CuPy at once for both major versions. |
|
Yes, please backport to 12.9. Sometimes we have also backported fixes to 13.0, if I recall correctly. Do we need that too? Thanks! |
|
I think we only need to maintain:
A few months ago, we would have done 12.9, 13.0, and 13.3, but we finished the 13.0 migration and bumped the channel pinnings to 13.4. |
|
@conda-forge-admin, please rerender |
…2026.10.15.13.54.1
|
@bdice, there's actually nothing to backport because CUDA 12.9 activation script does not explicitly add the cccl include directory. This explicit include was added in 13.0 by you! Do you recall why we didn't make the same change for 12.9? |
|
Ah, sorry my bad not thinking straight while juggling across meetings. The same change was not needed because the CCCL layout change happened at the CUDA 13.0 major boundary. |
|
Aha. Correct. We don't need 13.0 if conda-forge has completed migration, and we don't need 12.9 because this doesn't apply to the CUDA 12 layout. We're good to merge this as-is for only |
|
Thanks all! |
The added paths should be added as
-isystemto avoid overriding include dirs explicitly set in user build processes.For example some projects vendor CCCL headers and injecting these as
-Iwill easily take precedence.(I have to say, I am not sure if there is some other issue that using
-Iworked around of course...)Checklist