Skip to content

All projects to easier override include dirs (use -isystem) - #110

Merged
bdice merged 2 commits into
conda-forge:mainfrom
seberg:system-include
Oct 16, 2026
Merged

bdice merged 2 commits into
conda-forge:mainfrom
seberg:system-include

Conversation

@seberg

@seberg seberg commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

The added paths should be added as -isystem to avoid overriding include dirs explicitly set in user build processes.

For example some projects vendor CCCL headers and injecting these as -I will easily take precedence.

(I have to say, I am not sure if there is some other issue that using -I worked around of course...)

Checklist

@seberg
seberg requested a review from a team as a code owner October 15, 2026 07:39
@conda-forge-admin

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@seberg seberg changed the title All projects to easier override include dirs (use -Isystem) All projects to easier override include dirs (use -isystem) Oct 15, 2026

@robertmaynard robertmaynard left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we should only do this for include/cccl as those are marked as system includes by nvcc to support overrides, while the rest of the CUDA toolkit is provided as -I.

I don't think we want different includes taking priority depending on if the input is .cu versus .cpp.

The added paths should be added as `-isystem` to avoid overriding
include dirs explicitly set in user build processes.

For example some projects vendor CCCL headers and injecting these
as `-I` will easily take precedence.
@seberg

seberg commented Oct 16, 2026

Copy link
Copy Markdown
Contributor Author

Thanks, force-pushed to only apply this for the CCCL paths.

@carterbox

Copy link
Copy Markdown
Member

Thanks for reviewing, @robertmaynard!

@carterbox

Copy link
Copy Markdown
Member

@seberg, in your opinion, should we also backport this change to CUDA 12.9?

@leofang

leofang commented Oct 16, 2026

Copy link
Copy Markdown
Member

Preferably yes, because CuPy is affected and we want GCC/NVCC to behave correctly in terms of search behavior, in particular on which CCCL copy to use. If this is backported, we can rebuild CuPy at once for both major versions.

@bdice

bdice commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Yes, please backport to 12.9. Sometimes we have also backported fixes to 13.0, if I recall correctly. Do we need that too? Thanks!

@carterbox

Copy link
Copy Markdown
Member

I think we only need to maintain:

  • the latest release from each major version (12.9, 13.4)
  • the current channel pinnings (12.9, 13.4)

A few months ago, we would have done 12.9, 13.0, and 13.3, but we finished the 13.0 migration and bumped the channel pinnings to 13.4.

@carterbox

Copy link
Copy Markdown
Member

@conda-forge-admin, please rerender

@carterbox

Copy link
Copy Markdown
Member

@bdice, there's actually nothing to backport because CUDA 12.9 activation script does not explicitly add the cccl include directory. This explicit include was added in 13.0 by you!

seberg@daf3d08

Do you recall why we didn't make the same change for 12.9?

@leofang

leofang commented Oct 16, 2026

Copy link
Copy Markdown
Member

Ah, sorry my bad not thinking straight while juggling across meetings. The same change was not needed because the CCCL layout change happened at the CUDA 13.0 major boundary.

@bdice

bdice commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

Aha. Correct. We don't need 13.0 if conda-forge has completed migration, and we don't need 12.9 because this doesn't apply to the CUDA 12 layout. We're good to merge this as-is for only main (13.4). I'll press the button, I think we're ready.

@bdice
bdice merged commit 211e00e into conda-forge:main Oct 16, 2026
7 checks passed
@leofang

leofang commented Oct 16, 2026

Copy link
Copy Markdown
Member

Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants