-
-
Notifications
You must be signed in to change notification settings - Fork 19
MNT: Re-rendered with conda-smithy 2.0.1 #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
seems like the python 3.5 and numpy 1.12 options fails. But that's hard to say since the output just ends with a compiler message. |
there is a version check failure with numpy 1.12 due to a type error |
|
the current version doesn't work with the new numpy. The issue is fixed in master but it we have to wait for a new release to make update this repository for numpy 1.12 |
The patch is taken from the master branch of astropy. It should be removed when a new release is published.
|
@kain88-de - waiting a bit for the new release is OK, I plan to do a 1.3.1 very soon. Edit: now I see that you've already made a patched version, with is great! Thanks. |
|
@bsipocz The current version with the patch should work. If you want to wait for a 1.3.1 release before you upgrade this package I'm OK with that too. |
|
Lets have this if CI all green, I don't have a target date for the new release, just that it's happening soon (meaning something in a few days--weeks) |
|
I don't think I can do much about the failing windows builds. They are hitting an internal compiler error under x64 with python 3.x. |
|
Oh, yes that rings a bell, probably this is the same issue. We need to use the VS 2015 Update 2 for our windows CI, appveyor/ci#890 (comment) |
|
hmm, maybe it's not the same issue at the end as the local appveyor here is already set to use that one... |
|
|
||
| # Build on this OS until we can figure out how to workaround a compiler bug | ||
| # introduced in Update 3. | ||
| os: Visual Studio 2015 Update 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There has been a workaround in this repo that you also have in astropy. I deleted it with the update.
@conda-forge/core Is is OK if I add the workaround in the appveyor file again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should have checked the diff ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't worry I should have checked it to. Would have avoided my question ;)
This is a known bug with appveyor and astropy. Smithy updates seems to work fine with this change as well, it's just getting lost when we do it.
|
So Travis failed due to some timeouts of the http requests. I assume that they would have passed if not for that. For some reason I'm not able to restart the builds though. |
I restated Travis-CI for you.
If you want that ability you need to add yourself as a maintainer for this recipe. |
I'm OK with not having it. I was just thought I had it since travis offered me the button for a restart. Also the tests are passing :) |
updates numpy to 1.12