Skip to content

Conversation

@kain88-de
Copy link
Contributor

updates numpy to 1.12

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@kain88-de
Copy link
Contributor Author

seems like the python 3.5 and numpy 1.12 options fails. But that's hard to say since the output just ends with a compiler message.

@kain88-de
Copy link
Contributor Author

===== testing package: astropy-1.3-np112py36_0 =====

import: 'astropy'

Traceback (most recent call last):

  File "/Users/travis/miniconda3/conda-bld/astropy_1487090318682/test_tmp/run_test.py", line 27, in <module>

    import astropy

  File "/Users/travis/miniconda3/conda-bld/astropy_1487090318682/_t_env/lib/python3.6/site-packages/astropy/__init__.py", line 116, in <module>

    _check_numpy()

  File "/Users/travis/miniconda3/conda-bld/astropy_1487090318682/_t_env/lib/python3.6/site-packages/astropy/__init__.py", line 104, in _check_numpy

    from .utils import minversion

  File "/Users/travis/miniconda3/conda-bld/astropy_1487090318682/_t_env/lib/python3.6/site-packages/astropy/utils/__init__.py", line 20, in <module>

    from .compat.odict import OrderedDict

  File "/Users/travis/miniconda3/conda-bld/astropy_1487090318682/_t_env/lib/python3.6/site-packages/astropy/utils/compat/__init__.py", line 14, in <module>

    from .numpycompat import *

  File "/Users/travis/miniconda3/conda-bld/astropy_1487090318682/_t_env/lib/python3.6/site-packages/astropy/utils/compat/numpycompat.py", line 24, in <module>

    NUMPY_LT_1_12 = not minversion('numpy', '1.12dev')

  File "/Users/travis/miniconda3/conda-bld/astropy_1487090318682/_t_env/lib/python3.6/site-packages/astropy/utils/introspection.py", line 159, in minversion

    return parse_version(have_version) >= parse_version(version)

  File "/Users/travis/miniconda3/conda-bld/astropy_1487090318682/_t_env/lib/python3.6/distutils/version.py", line 70, in __ge__

    c = self._cmp(other)

  File "/Users/travis/miniconda3/conda-bld/astropy_1487090318682/_t_env/lib/python3.6/distutils/version.py", line 337, in _cmp

    if self.version < other.version:

TypeError: '<' not supported between instances of 'int' and 'str'

TESTS FAILED: astropy-1.3-np112py36_0

there is a version check failure with numpy 1.12 due to a type error

@kain88-de
Copy link
Contributor Author

the current version doesn't work with the new numpy. The issue is fixed in master but it we have to wait for a new release to make update this repository for numpy 1.12

astropy/astropy@027dbfa

The patch is taken from the master branch of astropy. It should be
removed when a new release is published.
@bsipocz
Copy link
Member

bsipocz commented Feb 15, 2017

@kain88-de - waiting a bit for the new release is OK, I plan to do a 1.3.1 very soon.

Edit: now I see that you've already made a patched version, with is great! Thanks.

@kain88-de
Copy link
Contributor Author

@bsipocz The current version with the patch should work. If you want to wait for a 1.3.1 release before you upgrade this package I'm OK with that too.

@bsipocz
Copy link
Member

bsipocz commented Feb 15, 2017

Lets have this if CI all green, I don't have a target date for the new release, just that it's happening soon (meaning something in a few days--weeks)

@kain88-de
Copy link
Contributor Author

I don't think I can do much about the failing windows builds. They are hitting an internal compiler error under x64 with python 3.x.

@bsipocz
Copy link
Member

bsipocz commented Feb 15, 2017

Oh, yes that rings a bell, probably this is the same issue. We need to use the VS 2015 Update 2 for our windows CI, appveyor/ci#890 (comment)

@bsipocz
Copy link
Member

bsipocz commented Feb 15, 2017

hmm, maybe it's not the same issue at the end as the local appveyor here is already set to use that one...


# Build on this OS until we can figure out how to workaround a compiler bug
# introduced in Update 3.
os: Visual Studio 2015 Update 2
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There has been a workaround in this repo that you also have in astropy. I deleted it with the update.

@conda-forge/core Is is OK if I add the workaround in the appveyor file again?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should have checked the diff ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't worry I should have checked it to. Would have avoided my question ;)

This is a known bug with appveyor and astropy. Smithy updates seems to
work fine with this change as well, it's just getting lost when we do
it.
@kain88-de
Copy link
Contributor Author

So Travis failed due to some timeouts of the http requests. I assume that they would have passed if not for that. For some reason I'm not able to restart the builds though.

@ocefpaf
Copy link
Member

ocefpaf commented Feb 17, 2017

So Travis failed due to some timeouts of the http requests. I assume that they would have passed if not for that.

I restated Travis-CI for you.

For some reason I'm not able to restart the builds though.

If you want that ability you need to add yourself as a maintainer for this recipe.

@kain88-de
Copy link
Contributor Author

If you want that ability you need to add yourself as a maintainer for this recipe.

I'm OK with not having it. I was just thought I had it since travis offered me the button for a restart.

Also the tests are passing :)

@ocefpaf ocefpaf merged commit a687918 into conda-forge:master Feb 17, 2017
@kain88-de kain88-de deleted the rerender branch February 17, 2017 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants