Skip to content

Use pytest directly from recipe instead of astropy.test - #151

Merged
Cadair merged 3 commits into
conda-forge:mainfrom
MridulS:use_pytest_directly
Nov 27, 2024
Merged

Cadair merged 3 commits into
conda-forge:mainfrom
MridulS:use_pytest_directly

Conversation

@MridulS

@MridulS MridulS commented Nov 26, 2024 •

Copy link
Copy Markdown
Member

This should hopefully work, let's see if the CI correctly picks it up :)

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@MridulS

MridulS commented Nov 26, 2024

Copy link
Copy Markdown
Member Author

@conda-forge-admin, please rerender

@conda-forge-admin

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

  • ❌ Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [74]

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12038128012. Examine the logs at this URL for more detail.

Comment thread recipe/meta.yaml Resolved
@Cadair

Cadair commented Nov 26, 2024

Copy link
Copy Markdown
Member

Thanks a lot for doing this. I would like to get all the package split stuff done first before we merge this though.

@conda-forge-admin

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12038134385. Examine the logs at this URL for more detail.

@conda-forge-admin

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@MridulS

MridulS commented Nov 26, 2024

Copy link
Copy Markdown
Member Author

Thanks a lot for doing this. I would like to get all the package split stuff done first before we merge this though.

Sure thing! Feel free to close this too if it's easier to just incorporate these changes in another PR :)

@bsipocz bsipocz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good, thanks!

@Cadair - yours should go in first, but the diff is too complicated to do a review from my phone. Hopefully someone else can give you a review of it while I'm travelling.

@Cadair
Cadair merged commit e73db21 into conda-forge:main Nov 27, 2024
@Cadair

Cadair commented Nov 27, 2024

Copy link
Copy Markdown
Member

Thanks a lot @MridulS 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants