Merged
Conversation
Contributor
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Member
|
Arr, dang: |
Member
|
On Windows, it looks like FFTW actually builds with (native) threads support, just not with OpenMP threads: |
Closed
ax3l
approved these changes
Feb 3, 2026
5 tasks
9b9e712 to
500056b
Compare
1 task
ax3l
approved these changes
Feb 3, 2026
ax3l
added a commit
to AMReX-Codes/amrex
that referenced
this pull request
Feb 6, 2026
## Summary - FFTW: Support Native Threading: Add an advanced `AMReX_FFTW_OMP_SUFFIX` flag to control alternate FFTW threading libs. Not ideal, but ok in a ditch. - Fix FindAMReXFFTW.cmake Message: The message for `AMReX_FFTW_IGNORE_OMP` was indicating the wrong value to ignore OMP search. ## Additional background See conda-forge/amrex-feedstock#72 (comment) Close conda-forge/amrex-feedstock#73 ## Checklist The proposed changes: - [ ] fix a bug or incorrect behavior in AMReX - [x] add new capabilities to AMReX - [ ] changes answers in the test suite to more than roundoff level - [ ] are likely to significantly affect the results of downstream AMReX users - [ ] include documentation in the code and/or rst files, if appropriate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is very likely that the current package version for this feedstock is out of date.
Checklist before merging this PR:
license_fileis packagedInformation about this PR:
@conda-forge-admin,please add bot automergein the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.bot-rerunlabel to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun botin a PR comment to have theconda-forge-adminadd it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/21613543334 - please use this URL for debugging.