Skip to content

amrex v26.02#72

Merged
ax3l merged 3 commits intoconda-forge:mainfrom
regro-cf-autotick-bot:26.02_h95c178
Feb 3, 2026
Merged

amrex v26.02#72
ax3l merged 3 commits intoconda-forge:mainfrom
regro-cf-autotick-bot:26.02_h95c178

Conversation

@regro-cf-autotick-bot
Copy link
Copy Markdown
Contributor

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/21613543334 - please use this URL for debugging.

@conda-forge-admin
Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/recipe.yaml) and found it was in an excellent condition.

@ax3l
Copy link
Copy Markdown
Member

ax3l commented Feb 3, 2026

Arr, dang:

 │ │ CMake Error at Tools/CMake/FindAMReXFFTW.cmake:77 (message):
 │ │   AMReX_OMP and AMReX_FFT are set, but provided FFTW does not provide OpenMP!
 │ │   Re-compile FFTW or set AMReX_FFTW_IGNORE_OMP=OFF

@ax3l
Copy link
Copy Markdown
Member

ax3l commented Feb 3, 2026

On Windows, it looks like FFTW actually builds with (native) threads support, just not with OpenMP threads:
https://github.com/conda-forge/fftw-feedstock/blob/8d084dcc26688b3dff49b1d397311ebbbed0dd06/recipe/bld_fftw.bat#L14-L16

@ax3l ax3l mentioned this pull request Feb 3, 2026
@ax3l ax3l merged commit fd9e37b into conda-forge:main Feb 3, 2026
2 of 35 checks passed
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 26.02_h95c178 branch February 3, 2026 06:03
ax3l added a commit to AMReX-Codes/amrex that referenced this pull request Feb 6, 2026
## Summary

- FFTW: Support Native Threading: Add an advanced
`AMReX_FFTW_OMP_SUFFIX` flag to control alternate FFTW threading libs.
Not ideal, but ok in a ditch.
- Fix FindAMReXFFTW.cmake Message: The message for
`AMReX_FFTW_IGNORE_OMP` was indicating the wrong value to ignore OMP
search.

## Additional background

See
conda-forge/amrex-feedstock#72 (comment)
Close conda-forge/amrex-feedstock#73

## Checklist

The proposed changes:
- [ ] fix a bug or incorrect behavior in AMReX
- [x] add new capabilities to AMReX
- [ ] changes answers in the test suite to more than roundoff level
- [ ] are likely to significantly affect the results of downstream AMReX
users
- [ ] include documentation in the code and/or rst files, if appropriate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants