Add team flag to fly command abort-build#7492
Merged
Conversation
Signed-off-by: Esteban Foronda <[email protected]>
I used the small refactor I made to add the team flag to the abort_build command Signed-off-by: Esteban Foronda <[email protected]>
EstebanFS
force-pushed
the
issue/5215-abort-build
branch
from
e2351bd to
b93ab0e
Compare
taylorsilva
requested changes
Sep 2, 2021
Member
taylorsilva
left a comment
taylorsilva
left a comment
There was a problem hiding this comment.
Missed one command in your refactor, jobs:
concourse/fly/commands/jobs.go
Line 18 in 7e04f7d
Nice refactor though! Should be wayyy easier to add the rest now :)
28 tasks
Signed-off-by: Esteban Foronda <[email protected]>
EstebanFS
force-pushed
the
issue/5215-abort-build
branch
from
f0a5a50 to
803b90b
Compare
Contributor
Author
|
Hey @taylorsilva , I just solved your comments, thanks for reviewing it! |
clarafu
changed the title
clarafu
changed the title
abort-build
clarafu
added
the
release/undocumented
This was referenced Nov 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed by this PR
closes various items in #5215
Notes to reviewer
Added team flag to fly command abort-build
Now you could add the
--teamflag to specify the team this action will be appliedRelease Note
teamflag to fly command abort-build, you could use this following the next formatfly -t dev abort-build --job some-pipeline/some-job -b 2 --team test