Conversation
zoetian
force-pushed
the
4196-single-team-scoped-fly-cmd
branch
9 times, most recently
from
71dff27 to
fad057c
Compare
zoetian
force-pushed
the
4196-single-team-scoped-fly-cmd
branch
3 times, most recently
from
726f94b to
8260e32
Compare
|
Hey @zoetian , As with just these four commands, we're already crossing the 1500+ lines of code of change, wdyt of splitting the next commands on other PRs? I imagine that doing so would make it simpler for reviewers to reason about the more isolated changes, as well as giving you the opportunity to better scope the comments on the implementation of each 🤔 Thanks! |
|
[ipm]: there might be some opportunity here for refactoring the |
|
[ipm]: let's wrap this PR around just these commands that we added, and then take some time on thinking on how we could gain more velocity with some refactoring to the testing |
zoetian
force-pushed
the
4196-single-team-scoped-fly-cmd
branch
12 times, most recently
from
023b1db to
cc6b74e
Compare
zoetian
force-pushed
the
4196-single-team-scoped-fly-cmd
branch
6 times, most recently
from
bccc869 to
5cb6ff4
Compare
taylorsilva
force-pushed
the
4196-single-team-scoped-fly-cmd
branch
4 times, most recently
from
34a7052 to
f125c98
Compare
|
@concourse/core-api This PR is ready for review please and thanks 😄 We're going to continue implementing this type of change for the remaining commands (see #4196, the single-team commands section) in other PR's. For now, this can be reviewed/merged in. |
zoetian
force-pushed
the
4196-single-team-scoped-fly-cmd
branch
from
a1b27b1 to
7fb32fa
Compare
zoetian
force-pushed
the
4196-single-team-scoped-fly-cmd
branch
2 times, most recently
from
f4e9936 to
a2bc75e
Compare
|
@concourse/core-api Sorry about the super long delay, this PR is ready for another round of review now. Thanks! |
zoetian
force-pushed
the
4196-single-team-scoped-fly-cmd
branch
3 times, most recently
from
1e19d80 to
1bc9f97
Compare
…npause-job` Signed-off-by: Zoe Tian <[email protected]> Co-authored-by: Bin Ju <[email protected]> Co-authored-by: Mike Hoskins <[email protected]> Co-authored-by: Taylor Silva <[email protected]> Co-authored-by: Bishoy Youssef <[email protected]>
aoldershaw
force-pushed
the
4196-single-team-scoped-fly-cmd
branch
from
1bc9f97 to
cb10a81
Compare
|
We were playing around with this patch and noticed an unexpected behaviour: $ fly -t dev pj -j doesnt/exist
error: doesnt/exist not found on team &{main %!s(*internal.connection=&{http://localhost:8080 0xc000273260 false 0xc0002732c0})}Probably we'd rather see something more like |
* switch from `-n/--team-name` to `--team` for overriding the target-default team * improve the help-text for `--team` flag * fix the error message when a job is not found * extract GetTeam helper and test it Signed-off-by: Aidan Oldershaw <[email protected]> Co-authored-by: Jamie Klassen <[email protected]>
jamieklassen
dismissed
vito’s stale review
@taylorsilva re-reviewed, and the review was super old
clarafu
added
the
release/documented
8 participants
Resolves part 1/2 to fixes #4196
As mentioned in the above issue, this PR is to address the single-team-scoped fly commands (i.e. scoped by pipeline/ resource/ build etc.)
This PR is ready for review
We're going to continue implementing this type of change for the remaining commands (see #4196, the single-team commands section) in other PR's. For now, this can be reviewed/merged in.