WIP: [Fly] Multi-team-scoped fly commands can display results by team name#4324
Closed
WIP: [Fly] Multi-team-scoped fly commands can display results by team name#4324
Conversation
27 tasks
zoetian
force-pushed
the
4196-fly-cmd-team-name
branch
from
b43d784 to
2588033
Compare
pivotal-bin-ju
force-pushed
the
4196-fly-cmd-team-name
branch
2 times, most recently
from
e8b3784 to
9d833c7
Compare
zoetian
force-pushed
the
4196-fly-cmd-team-name
branch
2 times, most recently
from
4b37a28 to
c5df7ee
Compare
clarafu
requested changes
Sep 12, 2019
zoetian
force-pushed
the
4196-fly-cmd-team-name
branch
from
c5df7ee to
c5c74e3
Compare
cirocosta
changed the title
zoetian
changed the title
zoetian
force-pushed
the
4196-fly-cmd-team-name
branch
4 times, most recently
from
74a0c6b to
770340d
Compare
zoetian
commented
Sep 17, 2019
zoetian
force-pushed
the
4196-fly-cmd-team-name
branch
6 times, most recently
from
2028e86 to
96cdbe1
Compare
Contributor
|
Can we squash the WIP commits (or remove the WIP if we would like the commit message to stay on master)? |
zoetian
force-pushed
the
4196-fly-cmd-team-name
branch
2 times, most recently
from
55ac3e1 to
9fd3f0a
Compare
taylorsilva
force-pushed
the
4196-fly-cmd-team-name
branch
3 times, most recently
from
552eb43 to
262eb81
Compare
zoetian
force-pushed
the
4196-fly-cmd-team-name
branch
2 times, most recently
from
cee1a18 to
73fc436
Compare
zoetian
commented
Oct 3, 2019
Contributor
Author
zoetian
left a comment
zoetian
left a comment
There was a problem hiding this comment.
Small changes that needs to be done
zoetian
force-pushed
the
4196-fly-cmd-team-name
branch
4 times, most recently
from
0bcca99 to
0f5ea99
Compare
vito
requested changes
Oct 10, 2019
zoetian
force-pushed
the
4196-fly-cmd-team-name
branch
from
0f5ea99 to
2d4f715
Compare
zoetian
force-pushed
the
4196-fly-cmd-team-name
branch
3 times, most recently
from
cc002da to
b000e37
Compare
- Adds `--team-name` flag to `fly containers` - Adds `--all-teams` flag to `fly containers` - Adds new api endpoint `/api/v1/containers` that returns all the containers based on the teams assigned to the user (all deployment containers in case of super-admin). - refactors atc/db/team.go to use `getContainersByTeamIds` function from the container_repository.go - Adds tests for various contianer parts (api, fly, db) Signed-off-by: Zoe Tian <[email protected]> Co-authored-by: Bin Ju <[email protected]> Co-authored-by: Bishoy Youssef <[email protected]> Co-authored-by: Taylor Silva <[email protected]> Co-authored-by: Mike Hoskins <[email protected]>
zoetian
force-pushed
the
4196-fly-cmd-team-name
branch
from
b000e37 to
9387838
Compare
Contributor
|
@taylorsilva this PR is part of an EPIC. What is the status atm? Do you still need this PR? Thx! |
taylorsilva
changed the title
Member
|
Changed title to WIP. I need to review this PR again, fix the conflicts, and potentially make changes to it as well before it's ready to merge. |
Member
|
Closing this PR. We'll think about how we want to implement these features later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #4196
This PR is for
fly -t TARGET containers(global api endpoints needed)Any team-scoped commands should accept a
-nor--teamparameter.