Skip to content

Comments

[Web] add super admin web ui functionalities #4319

Merged
jamieklassen merged 2 commits intomasterfrom
4194-super-admin-web-ui
Sep 4, 2019
Merged

[Web] add super admin web ui functionalities #4319
jamieklassen merged 2 commits intomasterfrom
4194-super-admin-web-ui

Conversation

@zoetian
Copy link
Contributor

@zoetian zoetian commented Aug 26, 2019

fixes #4194

There are a few areas in the web UI where the client tries to figure out if you're authorized to perform a certain action. These are:

  • pause/unpause a pipeline
  • force a check resource
  • expose a pipeline

This commit changes this behaviour to allow a user to perform these functions from the web ui.

@pivotal-jamie-klassen is there anywhere that we could be adding tests? thx!

cc @taylorsilva

@zoetian zoetian requested review from a team, jamieklassen and vito August 26, 2019 20:16
@zoetian zoetian force-pushed the 4194-super-admin-web-ui branch from e38e9d4 to e14bd1a Compare August 26, 2019 20:21
@zoetian zoetian force-pushed the 4194-super-admin-web-ui branch 3 times, most recently from 3f32937 to 442b27a Compare August 26, 2019 21:34
@taylorsilva taylorsilva force-pushed the 4194-super-admin-web-ui branch 2 times, most recently from fee2a3d to 45a3dba Compare August 27, 2019 14:31
- pause/unpause any pipeline
- expose/hide any pipeline
- check resources for any pipeline

Signed-off-by: Zoe Tian <[email protected]>
Co-authored-by: Taylor Silva <[email protected]>
@taylorsilva taylorsilva force-pushed the 4194-super-admin-web-ui branch from 45a3dba to 0b2a9cd Compare August 27, 2019 14:32
@taylorsilva
Copy link
Member

I didn't like the extra commits we had hanging on this PR so I rebased the branch on master and removed the unrelated commits from #4273

@jamieklassen jamieklassen added this to the v5.5.0 milestone Aug 27, 2019
@clarafu clarafu removed the request for review from a team September 4, 2019 14:03
@zoetian zoetian force-pushed the 4194-super-admin-web-ui branch 2 times, most recently from bff25d3 to 5c0e447 Compare September 4, 2019 17:52
Signed-off-by: Zoe Tian <[email protected]>
Co-authored-by: Taylor Silva <[email protected]>
Signed-off-by: Bin Ju <[email protected]>
@zoetian zoetian force-pushed the 4194-super-admin-web-ui branch from 5c0e447 to 0a886e6 Compare September 4, 2019 18:00
@zoetian zoetian requested a review from jamieklassen September 4, 2019 18:32
@jamieklassen jamieklassen merged commit 0f32fab into master Sep 4, 2019
@jamieklassen jamieklassen deleted the 4194-super-admin-web-ui branch September 4, 2019 18:37
@jamieklassen jamieklassen added the release/documented Documentation and release notes have been updated. label Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release/documented Documentation and release notes have been updated.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Web] Confirm UI functionality for Admin user

3 participants