super admin login to any team it owns#4273
Conversation
3fed22d to
e9f1ec4
Compare
e9f1ec4 to
ce79e18
Compare
b147cf4 to
f94e44f
Compare
54ee00a to
2c929e0
Compare
|
If this doesn't depend on #4238, I think it should be rebased without that |
45ebf8a to
2acb457
Compare
Signed-off-by: Zoe Tian <[email protected]> Signed-off-by: Taylor Silva <[email protected]> Co-authored-by: Bishoy Youssef <[email protected]> Co-authored-by: Bin Ju <[email protected]>
2acb457 to
eac0890
Compare
|
Hello, this PR is ready for review |
|
while reviewing this PR, I haven been experimenting with accessing a func unmarshalToken(tokenValue string) (map[string]interface{}, error) {
tokenContents := strings.Split(tokenValue, ".")
if len(tokenContents) < 2 {
// this is really bad and makes it hard to write proper integration tests
return nil, nil
}I hope to finish this experiment tomorrow. |
Signed-off-by: Bishoy Youssef <[email protected]> Co-authored-by: Taylor Silva <[email protected]>
c10447b to
0a20568
Compare
784e975 to
f0bc913
Compare
Unit tests for the API give us enough coverage Signed-off-by: Zoe Tian <[email protected]> Co-authored-by: Taylor Silva <[email protected]>
1f1c9bf to
3ab02cc
Compare
|
We got rid of the In order to break the
Therefore we're already covered by existing tests and don't need the new testflight tests. This is ready for review again @pivotal-jamie-klassen |
#4273 Signed-off-by: Jamie Klassen <[email protected]> Co-authored-by: James Thomson <[email protected]>
#4273 Signed-off-by: Jamie Klassen <[email protected]> Co-authored-by: James Thomson <[email protected]>
fixes: #4240
which allows super admin users to login to any team it doesn't on with fly command.
fly -t target -n team -u username -p password.