clearer errors and logging for limit-active-tasks#4208
Merged
Conversation
Signed-off-by: Denise Yu <[email protected]> Co-authored-by: Divya Dadlani <[email protected]>
kcmannem
approved these changes
Aug 1, 2019
Contributor
|
@ddadlani Thank you so much for improving this. |
jamieklassen
added
the
release/undocumented
jamieklassen
pushed a commit
that referenced
this pull request
Aug 26, 2019
#4118 #4148 #4208 #4277 #4142 #4221 #4293 Signed-off-by: James Thomson <[email protected]> Co-authored-by: Jamie Klassen <[email protected]>
matthewpereira
pushed a commit
that referenced
this pull request
Sep 5, 2019
#4118 #4148 #4208 #4277 #4142 #4221 #4293 Signed-off-by: James Thomson <[email protected]> Co-authored-by: Jamie Klassen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of merging in changes from
limit-active-tasksand refactoring the task step, we accidentally introduced an error in the logs where we tried to decrease the number of active tasks even if we were not usinglimit-active-tasks.This PR fixes that, as well as cleaning up other logging and naming for better clarity.
Signed-off-by: Denise Yu [email protected]
Co-authored-by: Divya Dadlani [email protected]