Conversation
Contributor
xtreme-sameer-vohra
commented
Jul 26, 2019
xtreme-sameer-vohra
commented
- task_step - move event processing block closer to consumer
- worker/client.go - avoid hoisting to improve readability
- task_step - move event processing block closer to consumer - worker/client.go - avoid hoisting to improve readability
ddadlani
approved these changes
Jul 29, 2019
ddadlani
pushed a commit
that referenced
this pull request
Jul 29, 2019
Minor refactor Signed-off-by: Divya Dadlani <[email protected]>
Contributor
|
@xtreme-sameer-vohra FYI don't forget to run For this PR I manually set it to passing since reverting it and then rebasing is a pain due to how long we've left #4109 open. |
jamieklassen
added
the
release/no-impact
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.