Add active tasks observability.#4142
Merged
ddadlani merged 1 commit intoconcourse:masterfrom Jul 23, 2019
Merged
Conversation
Follow-up on the new strategy `limit-active-tasks`, allow operators to follow the evolution of the number of active tasks in the system through fly and metrics. Show active tasks counter when `fly workers` is invoked with the --details option. Expand fly tests to cover for the above feature. Add active tasks to the workers metrics and the Prometheus exporter. Signed-off-by: Alessandro Degano <[email protected]>
aledegano
force-pushed
the
show_active_tasks_in_fly
branch
from
bd94e9c to
f0a5271
Compare
ddadlani
approved these changes
Jul 23, 2019
Contributor
ddadlani
left a comment
ddadlani
left a comment
There was a problem hiding this comment.
Thanks for adding this, @aledeganopix4d!
Just a small note for posterity: if the container placement strategy limit-active-tasks is not selected, the active_tasks column in fly workers as well as the active_tasks metric will always be 0. This value is meaningless without limit-active-tasks and does not reflect actual state.
jamieklassen
added
the
release/documented
jamieklassen
pushed a commit
that referenced
this pull request
Aug 26, 2019
#4118 #4148 #4208 #4277 #4142 #4221 #4293 Signed-off-by: James Thomson <[email protected]> Co-authored-by: Jamie Klassen <[email protected]>
matthewpereira
pushed a commit
that referenced
this pull request
Sep 5, 2019
#4118 #4148 #4208 #4277 #4142 #4221 #4293 Signed-off-by: James Thomson <[email protected]> Co-authored-by: Jamie Klassen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up on the new strategy
limit-active-tasks, allow operators to follow the evolution of the number of active tasks in the system throughflyand metrics.Show active tasks counter when
fly workersis invoked with the --details option.Expand fly tests to cover for the above feature.
Add active tasks to the workers metrics and the Prometheus exporter.
Follows up: #4118