Repository navigation
zeus_expected: new recipe - #23477
Conversation
This comment has been minimized.
This comment has been minimized.
1cbcab5 to
75106dc
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Hi! Thanks for taking the time to make your library available in Conan Center, we really appreciate it!
The recipe looks super good, I have nothing to suggest changing :)
(Don't worry about the CI, it will be retriggered automatically once the underlying infra issues have been fixed)
This comment has been minimized.
This comment has been minimized.
uilianries
left a comment
There was a problem hiding this comment.
Looking good, only some details.
This comment has been minimized.
This comment has been minimized.
|
Hi, @uilianries Though I've successfully run
conan-center-index/recipes/tl-expected/all/conanfile.py Lines 50 to 61 in 8585429 |
Co-authored-by: Uilian Ries <[email protected]>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@X1aomu Thank you for validating even Conan 1.x locally!
No, for new recipes, the same test_package folder should be used by both Conan 2.x and 1.x, with the exactly same code, no condition related to the version. The legacy test_v1_package folder was kept to prove compatibility with legacy Conan generators like
Do you mean this line, right? https://github.com/conan-io/conan-center-index/blob/master/recipes/tl-expected/all/conanfile.py#L50 It was added only for recipes in ConanCenterIndex that was present since Conan 1.x and then migrated to support Conan 2.x. As users would need time to migrate too, we kept both legacy and new generators supported in the recipes. But this a decision only for old recipes, new recipes like yours should ignore that rule and do not add support for those legacy generators.
About the hooks, don't worry too much about the warnings, it's more a notification than an obligation, some of them are covered already by Conan 2.x as built-in rule (e.g package name should be lower-case). In Conan 2.x we still don't have hooks in ConanCenterIndex, but we are designing other ways to check it. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
glad to see all checks passed for the first time :) I am going to investigate the bug further and merge the patch to upstream. |
uilianries
left a comment
There was a problem hiding this comment.
Almost good to go, only small details. Thank you for releasing a new version!
Co-authored-by: Uilian Ries <[email protected]>
Conan v1 pipeline ✔️All green in build 12 (
Conan v2 pipeline ✔️
All green in build 12 (
|
uilianries
left a comment
There was a problem hiding this comment.
LGTM. Thank you for your PR!
* zeus_expected: new recipe * zeus_expected: keep only the latest bugfix version as a new recipe * Apply suggestions from code review Co-authored-by: Uilian Ries <[email protected]> * zeus_expected: fix for linting * zeus_expected: bump to latest version * zeus_expected: test_package: removoe /Zc:__cplusplus as the new version doesn't require it * zeus_expected: testing: add patches * Apply suggestions from code review Co-authored-by: Uilian Ries <[email protected]> --------- Co-authored-by: Uilian Ries <[email protected]>
zeus_expected
A header-only library to backport
std::expectedto C++17.