Skip to content

Commit 9a2a6d0

Browse files
authored
chore(sdk/go)!: remove the Go SDK, now at github.com/ai-openshell/sdk-go (NVIDIA#5461)
* chore(sdk/go)!: remove the Go SDK, now at github.com/ai-openshell/sdk-go The Go SDK moved to github.com/ai-openshell/sdk-go (NVIDIA#5031), and the final sdk/go tag carries the deprecation notice. Remove what is left of it from this repository: - sdk/go/, tasks/go.toml, and the Go toolchain and tools in mise.toml and mise.lock (nothing else here is written in Go) - the Go entry, setup, and build steps in CodeQL, and sdk/go in the CodeQL config - sdk-go-tag.yml and the tag-sdk-go job in release-publish.yml, including its needs entry and the expected-publisher check - the Go SDK Freeze job in Branch Checks, which has nothing left to guard docs/sdk/go.mdx now shows the new module path, pins the SDK version to the gateway's, and keeps the migration steps from the old module that were reviewed on NVIDIA#5245. README, CONTRIBUTING, AGENTS, TESTING, CI.md, buf.yaml, and the Windows skill drop or redirect their sdk/go references. Existing sdk/go/vX.Y.Z tags stay, so builds that use the old module path keep working. BREAKING CHANGE: github.com/NVIDIA/OpenShell/sdk/go is no longer developed in this repository; use github.com/ai-openshell/sdk-go. Signed-off-by: Roland Huß <[email protected]> * ci: drop the go-sdk compatibility surface With sdk/go removed, the compatibility review has no Go SDK left to review. Remove go-sdk from the required surfaces in the review prompt and in the report validator, which rejects reviews that don't cover exactly the listed surfaces, and drop Go from the CI.md descriptions of the compatibility review, CodeQL, and the release publishers. Signed-off-by: Roland Huß <[email protected]> --------- Signed-off-by: Roland Huß <[email protected]>
1 parent f1ce693 commit 9a2a6d0

271 files changed

Lines changed: 45 additions & 77199 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.agents/skills/build-openshell-mxc-windows/SKILL.md‎

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -312,10 +312,9 @@ compatibility under emulation is not part of these tasks. The aggregate
312312
commands above on an ARM64 host.
313313

314314
The repository-wide `mise run pre-commit` task is also supported on Windows.
315-
Run `rust:lockfiles:check`, `sdk:ts:ci`, and `go:ci` through the Windows-aware
316-
tasks when validating those surfaces. Do not count the Go
317-
Windows ARM64 race-detector exclusion or POSIX permission-bit skips as security
318-
coverage. SDK test dependencies must remain at their lockfile versions.
315+
Run `rust:lockfiles:check` and `sdk:ts:ci` through the Windows-aware tasks
316+
when validating those surfaces. Do not count POSIX permission-bit skips as
317+
security coverage. SDK test dependencies must remain at their lockfile versions.
319318
Its Rust check, Clippy, and test dependencies enter the same MSVC environment
320319
for the native host target and use an inherited compiler wrapper when it is
321320
available. Linux glibc

‎.github/codeql/codeql-config.yml‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ name: OpenShell Rust and SDKs
66
paths:
77
- crates
88
- examples
9-
- sdk/go
109
- sdk/typescript/src
1110
- python/openshell
1211

‎.github/prompts/compatibility-review.md‎

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -113,8 +113,9 @@ needed.
113113

114114
## Required surfaces
115115

116-
Account for every surface: `rust-sdk`, `python-sdk`, `go-sdk`, `typescript-sdk`,
117-
`api-behavior`, `cli`, `configuration`, `policy`, `helm`, and `state`.
116+
Account for every surface: `rust-sdk`, `python-sdk`, `typescript-sdk`,
117+
`api-behavior`, `cli`, `configuration`, `policy`, `helm`, and `state`. The Go
118+
SDK moved to ai-openshell/sdk-go and is not a surface of this repository.
118119

119120
Scope `rust-sdk` to the public API reachable through `openshell-sdk`, including
120121
its `raw` module and transitive public re-exports. Trace the export path before
@@ -126,16 +127,6 @@ generated server-trait changes reachable through `raw::proto`, identifying
126127
mock/server implementers as affected consumers and distinguishing them from
127128
unaffected client callers.
128129

129-
For `go-sdk`, adopt the [Go struct-literal compatibility convention](https://go.dev/doc/go1compat):
130-
adding fields to exported structs is additive when existing keyed literals remain
131-
valid and omitted fields preserve existing behavior. Do not report a break solely
132-
because unkeyed (positional) literals need updating, unless the baseline explicitly
133-
guarantees that construction form. Still inspect existing field names and types,
134-
zero-value behavior, comparability (equality and map keys), and serialization
135-
contracts; a field addition can break those independently. Follow the
136-
[Go module compatibility guidance](https://go.dev/blog/module-compatibility#maintaining-struct-compatibility)
137-
for these limits. This exception applies only to Go struct-field additions.
138-
139130
Check exported signatures/types, generated and handwritten SDK behavior,
140131
serialization and error contracts, command flags and documented machine-readable
141132
output, config/default semantics, policy formats, chart values, and persisted

‎.github/workflows/branch-checks.yml‎

Lines changed: 0 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -608,39 +608,6 @@ jobs:
608608
609609
- name: Test release qualification summary
610610
run: mise run test:qualification-summary
611-
sdk-go-freeze:
612-
# The Go SDK moved to ai-openshell/sdk-go (#5031). Its directory stays only
613-
# until the final deprecated sdk/go tag exists, so PRs must not add or change
614-
# files in it. Deleting files is allowed (the removal PR), and so are the
615-
# moved notice and the deprecation comment in README.md and go.mod.
616-
# Merge queue runs skip this job; the PR already passed it on its mirror.
617-
name: Go SDK Freeze
618-
needs: pr_metadata
619-
if: needs.pr_metadata.outputs.should_run == 'true' && github.event_name == 'push'
620-
runs-on: ubuntu-latest
621-
timeout-minutes: 5
622-
steps:
623-
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
624-
with:
625-
fetch-depth: 0
626-
persist-credentials: false
627-
628-
- name: Reject changes to sdk/go
629-
env:
630-
BASE_SHA: ${{ needs.pr_metadata.outputs.base_sha }}
631-
run: |
632-
set -euo pipefail
633-
changed=$(git diff --name-only --diff-filter=d "${BASE_SHA}...HEAD" -- \
634-
sdk/go ':!sdk/go/README.md' ':!sdk/go/go.mod')
635-
if [ -z "$changed" ]; then
636-
echo "No added or changed files under sdk/go."
637-
exit 0
638-
fi
639-
echo "::error title=Go SDK moved::The Go SDK moved to https://github.com/ai-openshell/sdk-go. Drop the sdk/go changes from this PR and open SDK changes there. Regenerated bindings are not needed here; sdk-go regenerates them from core releases."
640-
echo "Changed files under sdk/go:"
641-
echo "$changed"
642-
exit 1
643-
644611
python-sdk-freeze:
645612
# The Python SDK moved to ai-openshell/sdk-python (#5287), which imported it
646613
# at v0.1.7. Its files stay only until core removes them, so PRs must not

‎.github/workflows/codeql.yml‎

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,6 @@ jobs:
4040
include:
4141
- language: rust
4242
build-mode: none
43-
- language: go
44-
build-mode: manual
4543
- language: python
4644
build-mode: none
4745
- language: javascript-typescript
@@ -53,25 +51,13 @@ jobs:
5351
ref: ${{ inputs.candidate_ref && format('refs/tags/{0}', inputs.candidate_ref) || '' }}
5452
persist-credentials: false
5553

56-
- name: Set up Go
57-
if: matrix.language == 'go'
58-
uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0
59-
with:
60-
go-version-file: sdk/go/go.mod
61-
cache-dependency-path: sdk/go/go.sum
62-
6354
- name: Initialize CodeQL
6455
uses: github/codeql-action/init@24c54180a607b1449ed407dd24f251e4e9147c8d # v4.38.3
6556
with:
6657
languages: ${{ matrix.language }}
6758
build-mode: ${{ matrix.build-mode }}
6859
config-file: ./.github/codeql/codeql-config.yml
6960

70-
- name: Build Go SDK
71-
if: matrix.language == 'go'
72-
working-directory: sdk/go
73-
run: go build ./...
74-
7561
- name: Analyze
7662
id: analyze
7763
uses: github/codeql-action/analyze@24c54180a607b1449ed407dd24f251e4e9147c8d # v4.38.3

‎.github/workflows/release-publish.yml‎

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -543,17 +543,6 @@ jobs:
543543
npm-version: ${{ inputs.npm-version }}
544544
make-latest: ${{ inputs.make-latest }}
545545

546-
tag-sdk-go:
547-
name: Tag Go SDK
548-
needs: release
549-
if: ${{ !inputs.is-prerelease }}
550-
permissions:
551-
contents: write
552-
uses: ./.github/workflows/sdk-go-tag.yml
553-
with:
554-
version: ${{ inputs.semver }}
555-
source-sha: ${{ inputs.source-sha }}
556-
557546
# GitHub treats skipped jobs as passing, so a publisher that never ran would
558547
# leave the run green. Fail when any publisher expected for this release kind
559548
# did not succeed, so callers' failure notifications fire.
@@ -567,7 +556,6 @@ jobs:
567556
- publish-snap
568557
- publish-prerelease-snap
569558
- publish-sdk-typescript
570-
- tag-sdk-go
571559
if: always()
572560
runs-on: ubuntu-latest
573561
timeout-minutes: 2
@@ -583,7 +571,7 @@ jobs:
583571
if [[ "${IS_PRERELEASE}" == "true" ]]; then
584572
expected+=(publish-prerelease-snap)
585573
else
586-
expected+=(publish-sdk-typescript tag-sdk-go)
574+
expected+=(publish-sdk-typescript)
587575
if [[ "${MAKE_LATEST}" == "true" ]]; then
588576
expected+=(publish-snap)
589577
fi

‎.github/workflows/sdk-go-tag.yml‎

Lines changed: 0 additions & 58 deletions
This file was deleted.

‎AGENTS.md‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -196,10 +196,9 @@ Follow `CONTRIBUTING.md` and `create-github-pr`. Authors without target-reposito
196196
- Sign off on each commit for DCO compliance. Use the `--signoff` option to `git commit` to add the `Signed-off-by` footer to ensure the user's configured email address is used.
197197
- Never mention Claude or any AI agent in commits, PR descriptions, or issues (no author attribution, no Co-Authored-By, no "Generated with" footers)
198198

199-
## Go SDK (`sdk/go/`)
199+
## Go SDK
200200

201-
- The Go SDK moved to [ai-openshell/sdk-go](https://github.com/ai-openshell/sdk-go) (module `github.com/ai-openshell/sdk-go`). Open SDK changes there.
202-
- `sdk/go/` is frozen until it is removed; Branch Checks fails PRs that change it. Proto changes do not need regenerated Go bindings.
201+
- The Go SDK lives in [ai-openshell/sdk-go](https://github.com/ai-openshell/sdk-go) (module `github.com/ai-openshell/sdk-go`). Open SDK changes, including dependency and security updates, there; proto changes here need no Go bindings.
203202

204203
## Python SDK (`python/openshell/`)
205204

‎CI.md‎

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -94,8 +94,8 @@ qualification. Branch checks compare the prospective merge tree with its target,
9494
using workflow-revision review tooling and the target's tag-derived train policy.
9595
Release qualification reviews the cumulative diff from the previous reachable
9696
stable release to the exact candidate commit, using the same tag-derived
97-
patch/minor policy as the protobuf check. It reviews public Rust, Python, Go,
98-
and TypeScript SDKs, API behavior, CLI contracts, configuration, policy, Helm,
97+
patch/minor policy as the protobuf check. It reviews public Rust, Python, and
98+
TypeScript SDKs, API behavior, CLI contracts, configuration, policy, Helm,
9999
and persisted state.
100100
Both Codex workflows share the `codex-release-review` concurrency group with
101101
`queue: max`, so only one review runs at a time and up to 100 pending reviews
@@ -245,7 +245,7 @@ scanners upload results directly:
245245
warn-only mode. A preflight turns an unavailable GitHub Dependency Graph into
246246
a warning, so the workflow remains neutral until the repository feature is
247247
available.
248-
- `CodeQL` analyzes product Rust code, examples, and the Go, Python, and
248+
- `CodeQL` analyzes product Rust code, examples, and the Python and
249249
TypeScript SDKs. Rust `cfg(test)` blocks, Rust integration-test targets, and
250250
E2E test code are excluded. It runs nightly on `main`, remains manually
251251
dispatchable for diagnostics, uploads results to Code Scanning, and retains
@@ -707,7 +707,7 @@ The bot's full administrator documentation is internal to NVIDIA. The only comma
707707
| `.github/workflows/e2e-label-help.yml` | When a `test:e2e*` label is applied, posts a PR comment telling the maintainer the next manual step (re-run an existing workflow run, or `/ok to test <SHA>` to refresh the mirror). |
708708
| `.github/workflows/workflow-security.yml` | Runs informational Actionlint and High-severity Zizmor reports on GitHub-hosted runners. |
709709
| `.github/workflows/dependency-review.yml` | Reports dependency changes when GitHub Dependency Graph is available; otherwise publishes a neutral warning. |
710-
| `.github/workflows/codeql.yml` | Runs nightly informational CodeQL analysis on `main` for Rust and the Go, Python, and TypeScript SDKs and retains SARIF artifacts. |
710+
| `.github/workflows/codeql.yml` | Runs nightly informational CodeQL analysis on `main` for Rust and the Python and TypeScript SDKs and retains SARIF artifacts. |
711711
| `.github/workflows/codex-security.yml` | Advisory scan during prerelease qualification; scans the stable-to-candidate diff and publishes train-scoped SARIF on `main`. |
712712
| `.github/workflows/codex-compatibility.yml` | Reviews branch and cumulative tagged-release compatibility with Codex and retains advisory findings, PR acknowledgements, and coverage; it does not gate merging or publication. |
713713
| `.github/workflows/trivy-changes.yml` | Blocks pull requests and merge groups that introduce new High or Critical Helm or Dockerfile misconfigurations. |
@@ -726,13 +726,12 @@ Each step that publishes to an external registry, store, or site lives in its ow
726726
| `.github/workflows/release-auto-tag.yml` | Weekdays at 14:00 Europe/Zurich, tags the next `-pre.N` on `main` when commits landed since the latest one, then dispatches Pre-release. It skips when the train has no `-pre.1` or its version is already stable, so push each train's `-pre.1` tag by hand. |
727727
| `.github/workflows/release-prerelease.yml` | Pre-release orchestrator, triggered by prerelease tag pushes or dispatched by Release Auto-Tag or manually. A tagless dispatch creates the next candidate on its branch; explicit tags select existing candidates. Builds, then publishes and qualifies in parallel. Qualification failure fails the run and sends the failure notification; published artifacts remain available. |
728728
| `.github/workflows/release-build.yml` | Shared version computation, binary and image builds, and package builds. Validates that the tag matches the caller's release kind. |
729-
| `.github/workflows/release-publish.yml` | Shared artifact assembly, OCI image tags and Helm chart publication, and package publication. Stable releases also publish release-labeled public schemas to Buf (`BUF_TOKEN` required) and GitHub Releases, and call the snap, npm, and Go SDK publishers. The Python SDK is released from [ai-openshell/sdk-python](https://github.com/ai-openshell/sdk-python), so no GitHub Release carries a wheel. |
729+
| `.github/workflows/release-publish.yml` | Shared artifact assembly, OCI image tags and Helm chart publication, and package publication. Stable releases also publish release-labeled public schemas to Buf (`BUF_TOKEN` required) and GitHub Releases, and call the snap and npm publishers. The Python SDK is released from [ai-openshell/sdk-python](https://github.com/ai-openshell/sdk-python), so no GitHub Release carries a wheel. |
730730
| `.github/workflows/release-notes.yml` | Shared prompt-driven release notes generation through Inference Hub, used by prerelease previews, notes-only previews, and stable releases. Stable releases reuse the promoted prerelease's preview when available. |
731731
| `.github/workflows/release-qualification.yml` | Reusable qualification suites and result aggregation. Runs security scans, conformance and feature integration, Docker and VM E2E, protobuf compatibility, and advisory compatibility review. |
732732
| `.github/workflows/snap-package.yml` | Builds snap and component artifacts for Release Dev, Release, and Pre-release without Store credentials or publication. |
733733
| `.github/workflows/snap-publish.yml` | Uploads existing snap and component artifacts directly to a Store channel without rebuilding. Release Dev uses `latest/edge`, Pre-release uses `latest/beta`, and Release uses `latest/stable` for the stable rebuild. Uploads queue per channel and architecture, so tagged beta and stable jobs recheck repository tags after earlier publication finishes and before updating their floating channels. Manual dispatch uploads the `snap-linux-*` artifacts from `artifact-run-id`. |
734734
| `.github/workflows/sdk-typescript-publish.yml` | Publishes the TypeScript SDK to GitHub Packages. Called by stable Release; manual dispatch publishes a given tag and npm version. |
735-
| `.github/workflows/sdk-go-tag.yml` | Creates the `sdk/go/vX.Y.Z` tag and asks the Go module proxy to fetch it. Called by stable Release; manual dispatch tags a given version and commit. |
736735
| `.github/workflows/release-canary.yml` | Smoke-tests published dev artifacts in the `macos`, `ubuntu-deb`, `ubuntu-snap-system-docker`, `fedora`, and `kubernetes` (kind + Helm) jobs. Each job reaches its gateway and creates, exercises, and deletes a sandbox. The `ubuntu-snap-system-docker` job verifies a compatible system Docker lifecycle, while `ubuntu-snap-docker-preflight` tests fail-fast behavior when Docker is absent or supplied by the Docker snap. The positive snap lane also runs a local policy containment check with the packaged prover. It runs automatically after `Release Dev` succeeds and supports manual dispatch (`gh workflow run release-canary.yml --ref <branch>`). See the `test-release-canary` skill for the playbook and local kind reproduction. |
737736

738737
## Required status contexts

‎CONTRIBUTING.md‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -383,7 +383,6 @@ These are the primary `mise` tasks for day-to-day development:
383383
| `crates/openshell-policy-schema/` | Canonical authored policy DTOs and bounded YAML/JSON parser |
384384
| `crates/openshell-prover-cli/` | Standalone local policy boundary checker |
385385
| `python/` | Python SDK (frozen, moved to ai-openshell/sdk-python) |
386-
| `sdk/go/` | Go SDK (types, gRPC clients, converters) |
387386
| `sdk/typescript/` | TypeScript SDK (Connect client and generated protobuf bindings) |
388387
| `proto/` | Protocol buffer definitions and [public API conventions](proto/README.md) |
389388
| `tasks/` | `mise` task definitions and build scripts |

0 commit comments

Comments
 (0)