You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 9a2a6d0
Browse filesBrowse the repository at this point in the historyBrowse files
chore(sdk/go)!: remove the Go SDK, now at github.com/ai-openshell/sdk-go (NVIDIA#5461)
* chore(sdk/go)!: remove the Go SDK, now at github.com/ai-openshell/sdk-go
The Go SDK moved to github.com/ai-openshell/sdk-go (NVIDIA#5031), and the
final sdk/go tag carries the deprecation notice. Remove what is left of
it from this repository:
- sdk/go/, tasks/go.toml, and the Go toolchain and tools in mise.toml
and mise.lock (nothing else here is written in Go)
- the Go entry, setup, and build steps in CodeQL, and sdk/go in the
CodeQL config
- sdk-go-tag.yml and the tag-sdk-go job in release-publish.yml,
including its needs entry and the expected-publisher check
- the Go SDK Freeze job in Branch Checks, which has nothing left to
guard
docs/sdk/go.mdx now shows the new module path, pins the SDK version to
the gateway's, and keeps the migration steps from the old module that
were reviewed on NVIDIA#5245. README, CONTRIBUTING, AGENTS, TESTING, CI.md,
buf.yaml, and the Windows skill drop or redirect their sdk/go
references. Existing sdk/go/vX.Y.Z tags stay, so builds that use the
old module path keep working.
BREAKING CHANGE: github.com/NVIDIA/OpenShell/sdk/go is no longer
developed in this repository; use github.com/ai-openshell/sdk-go.
Signed-off-by: Roland Huß <[email protected]>
* ci: drop the go-sdk compatibility surface
With sdk/go removed, the compatibility review has no Go SDK left to
review. Remove go-sdk from the required surfaces in the review prompt
and in the report validator, which rejects reviews that don't cover
exactly the listed surfaces, and drop Go from the CI.md descriptions of
the compatibility review, CodeQL, and the release publishers.
Signed-off-by: Roland Huß <[email protected]>
---------
Signed-off-by: Roland Huß <[email protected]>
mock/server implementers as affected consumers and distinguishing them from
127
128
unaffected client callers.
128
129
129
-
For `go-sdk`, adopt the [Go struct-literal compatibility convention](https://go.dev/doc/go1compat):
130
-
adding fields to exported structs is additive when existing keyed literals remain
131
-
valid and omitted fields preserve existing behavior. Do not report a break solely
132
-
because unkeyed (positional) literals need updating, unless the baseline explicitly
133
-
guarantees that construction form. Still inspect existing field names and types,
134
-
zero-value behavior, comparability (equality and map keys), and serialization
135
-
contracts; a field addition can break those independently. Follow the
echo "::error title=Go SDK moved::The Go SDK moved to https://github.com/ai-openshell/sdk-go. Drop the sdk/go changes from this PR and open SDK changes there. Regenerated bindings are not needed here; sdk-go regenerates them from core releases."
640
-
echo "Changed files under sdk/go:"
641
-
echo "$changed"
642
-
exit 1
643
-
644
611
python-sdk-freeze:
645
612
# The Python SDK moved to ai-openshell/sdk-python (#5287), which imported it
646
613
# at v0.1.7. Its files stay only until core removes them, so PRs must not
Copy file name to clipboardExpand all lines: AGENTS.md
+2-3Lines changed: 2 additions & 3 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -196,10 +196,9 @@ Follow `CONTRIBUTING.md` and `create-github-pr`. Authors without target-reposito
196
196
- Sign off on each commit for DCO compliance. Use the `--signoff` option to `git commit` to add the `Signed-off-by` footer to ensure the user's configured email address is used.
197
197
- Never mention Claude or any AI agent in commits, PR descriptions, or issues (no author attribution, no Co-Authored-By, no "Generated with" footers)
198
198
199
-
## Go SDK (`sdk/go/`)
199
+
## Go SDK
200
200
201
-
- The Go SDK moved to [ai-openshell/sdk-go](https://github.com/ai-openshell/sdk-go) (module `github.com/ai-openshell/sdk-go`). Open SDK changes there.
202
-
-`sdk/go/` is frozen until it is removed; Branch Checks fails PRs that change it. Proto changes do not need regenerated Go bindings.
201
+
- The Go SDK lives in [ai-openshell/sdk-go](https://github.com/ai-openshell/sdk-go) (module `github.com/ai-openshell/sdk-go`). Open SDK changes, including dependency and security updates, there; proto changes here need no Go bindings.
warn-only mode. A preflight turns an unavailable GitHub Dependency Graph into
246
246
a warning, so the workflow remains neutral until the repository feature is
247
247
available.
248
-
-`CodeQL` analyzes product Rust code, examples, and the Go, Python, and
248
+
-`CodeQL` analyzes product Rust code, examples, and the Python and
249
249
TypeScript SDKs. Rust `cfg(test)` blocks, Rust integration-test targets, and
250
250
E2E test code are excluded. It runs nightly on `main`, remains manually
251
251
dispatchable for diagnostics, uploads results to Code Scanning, and retains
@@ -707,7 +707,7 @@ The bot's full administrator documentation is internal to NVIDIA. The only comma
707
707
| `.github/workflows/e2e-label-help.yml` | When a `test:e2e*` label is applied, posts a PR comment telling the maintainer the next manual step (re-run an existing workflow run, or `/ok to test <SHA>` to refresh the mirror). |
708
708
| `.github/workflows/workflow-security.yml` | Runs informational Actionlint and High-severity Zizmor reports on GitHub-hosted runners. |
709
709
| `.github/workflows/dependency-review.yml` | Reports dependency changes when GitHub Dependency Graph is available; otherwise publishes a neutral warning. |
710
-
| `.github/workflows/codeql.yml` | Runs nightly informational CodeQL analysis on `main` for Rust and the Go, Python, and TypeScript SDKs and retains SARIF artifacts. |
710
+
| `.github/workflows/codeql.yml` | Runs nightly informational CodeQL analysis on `main` for Rust and the Python and TypeScript SDKs and retains SARIF artifacts. |
711
711
| `.github/workflows/codex-security.yml` | Advisory scan during prerelease qualification; scans the stable-to-candidate diff and publishes train-scoped SARIF on `main`. |
712
712
| `.github/workflows/codex-compatibility.yml` | Reviews branch and cumulative tagged-release compatibility with Codex and retains advisory findings, PR acknowledgements, and coverage; it does not gate merging or publication. |
713
713
| `.github/workflows/trivy-changes.yml` | Blocks pull requests and merge groups that introduce new High or Critical Helm or Dockerfile misconfigurations. |
@@ -726,13 +726,12 @@ Each step that publishes to an external registry, store, or site lives in its ow
726
726
| `.github/workflows/release-auto-tag.yml` | Weekdays at 14:00 Europe/Zurich, tags the next `-pre.N` on `main` when commits landed since the latest one, then dispatches Pre-release. It skips when the train has no `-pre.1` or its version is already stable, so push each train's `-pre.1` tag by hand. |
727
727
| `.github/workflows/release-prerelease.yml` | Pre-release orchestrator, triggered by prerelease tag pushes or dispatched by Release Auto-Tag or manually. A tagless dispatch creates the next candidate on its branch; explicit tags select existing candidates. Builds, then publishes and qualifies in parallel. Qualification failure fails the run and sends the failure notification; published artifacts remain available. |
728
728
| `.github/workflows/release-build.yml` | Shared version computation, binary and image builds, and package builds. Validates that the tag matches the caller's release kind. |
729
-
| `.github/workflows/release-publish.yml` | Shared artifact assembly, OCI image tags and Helm chart publication, and package publication. Stable releases also publish release-labeled public schemas to Buf (`BUF_TOKEN` required) and GitHub Releases, and call the snap, npm, and Go SDK publishers. The Python SDK is released from [ai-openshell/sdk-python](https://github.com/ai-openshell/sdk-python), so no GitHub Release carries a wheel. |
729
+
| `.github/workflows/release-publish.yml` | Shared artifact assembly, OCI image tags and Helm chart publication, and package publication. Stable releases also publish release-labeled public schemas to Buf (`BUF_TOKEN` required) and GitHub Releases, and call the snapand npm publishers. The Python SDK is released from [ai-openshell/sdk-python](https://github.com/ai-openshell/sdk-python), so no GitHub Release carries a wheel. |
730
730
| `.github/workflows/release-notes.yml` | Shared prompt-driven release notes generation through Inference Hub, used by prerelease previews, notes-only previews, and stable releases. Stable releases reuse the promoted prerelease's preview when available. |
731
731
| `.github/workflows/release-qualification.yml` | Reusable qualification suites and result aggregation. Runs security scans, conformance and feature integration, Docker and VM E2E, protobuf compatibility, and advisory compatibility review. |
732
732
| `.github/workflows/snap-package.yml` | Builds snap and component artifacts for Release Dev, Release, and Pre-release without Store credentials or publication. |
733
733
| `.github/workflows/snap-publish.yml` | Uploads existing snap and component artifacts directly to a Store channel without rebuilding. Release Dev uses `latest/edge`, Pre-release uses `latest/beta`, and Release uses `latest/stable` for the stable rebuild. Uploads queue per channel and architecture, so tagged beta and stable jobs recheck repository tags after earlier publication finishes and before updating their floating channels. Manual dispatch uploads the `snap-linux-*` artifacts from `artifact-run-id`. |
734
734
| `.github/workflows/sdk-typescript-publish.yml` | Publishes the TypeScript SDK to GitHub Packages. Called by stable Release; manual dispatch publishes a given tag and npm version. |
735
-
| `.github/workflows/sdk-go-tag.yml` | Creates the `sdk/go/vX.Y.Z` tag and asks the Go module proxy to fetch it. Called by stable Release; manual dispatch tags a given version and commit. |
736
735
| `.github/workflows/release-canary.yml` | Smoke-tests published dev artifacts in the `macos`, `ubuntu-deb`, `ubuntu-snap-system-docker`, `fedora`, and `kubernetes` (kind + Helm) jobs. Each job reaches its gateway and creates, exercises, and deletes a sandbox. The `ubuntu-snap-system-docker` job verifies a compatible system Docker lifecycle, while `ubuntu-snap-docker-preflight` tests fail-fast behavior when Docker is absent or supplied by the Docker snap. The positive snap lane also runs a local policy containment check with the packaged prover. It runs automatically after `Release Dev` succeeds and supports manual dispatch (`gh workflow run release-canary.yml --ref <branch>`). See the `test-release-canary` skill for the playbook and local kind reproduction. |
0 commit comments