Fix --no-scripts disabling events for plugins #9942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This change basically means that |
Member
|
I think this is fine as is. Keeping setRunScripts in those places is probably fine, because when Installer is running in dry-run mode, I think suppressing the dispatching of events completely is probably a good idea still to avoid having plugins doing weird stuff while we output operations which aren't being executed. This is done automatically when dry-run is enabled, so I deprecated the setter in Installer. |
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Jun 15, 2021
This PR was merged into the 5.3 branch. Discussion ---------- [Runtime] Add a note for --no-scripts Ref composer/composer#9942 I think it's worth documenting :) Commits ------- 53a1829 [Runtime] Add a note for --no-scripts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, when composer runs with
--no-scripts, it not only disables "scripts" entries from the composer.json file, but it also prevents plugins from actually doing anything. This PR fixes it.