Fire POST_FILE_DOWNLOAD event for metadata fetched by ComposerRepository #9822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Please check out my changes, see if that works for you? I figured passing the repository to metadata and having an array to allow for future additions in a BC way there if needed would be good to have. |
Contributor
Author
|
I think those changes look great, and will serve our purposes beautifully. I considered adding the repository as context, but for TUF's purposes, the response was more valuable. But I agree that passing both in an array is more flexible and future-proof. Thanks! |
Member
|
Alright then let's merge this for now, not sure what the timeline is on 2.1 tho but at least you can keep moving forwards based on snapshot builds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is spun off from discussion in #9740 and #9819.
Right now, it's not possible for plugins (in this case, specifically php-tuf/composer-integration) to react to Composer downloading package metadata. The methods which do that grunt work cannot be overridden because they're private, and no event is dispatched after the metadata is downloaded. @Seldaek suggested modifying ComposerRepository to fire the POST_FILE_DOWNLOAD plugin event after metadata is downloaded, but before it is cached. This PR implements that.
This requires changes to the PostFileDownloadEvent class. Namely, it has be able to accept a type (
packageormetadata, similar to what PreFileDownloadEvent already does) and additional context beyond just an instance ofPackageInterface.