Test PHP 8.0 with lowest dependencies #8878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
You probably need to add --with-dependencies to the require command at that hopefully lets it run further. |
WyriHaximus
force-pushed
the
test-php-8-lowest
branch
from
221d4e2 to
85605c3
Compare
Contributor
Author
|
Yeah looks like it, the goods news it seems like no |
Member
|
So you think it's mis-use of the react/promise 2.x code? Because it does pass all tests with 2.x on php 7.4 so that's strange.. But maybe I can investigate locally by hooking into the react code at the point where it fails on php 8 and throwing there if it does pass in an array. |
Contributor
Author
|
No clue yet to be honest. It could also be other code that isn't PHP 8 ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: reactphp/promise#161 (comment)