Check for local changes when switching a package from source to dist#12912
Merged
Seldaek merged 1 commit intoJun 3, 2026
Merged
Conversation
On a source to dist switch DownloadManager::update removed the install without the local-changes guard a same-source update runs, wiping the checkout's .git and any local commits. The source downloader's uninstall guard now runs first on a type change so the switch aborts on uncommitted or unpushed work. Fixes composer#11567
Member
|
Cool, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
composer updatethat switches a package from a source install to a dist install wiped the whole directory, including its.gitand any local commits, because the removal skipped the local-changes check that a same-source update runs. The source downloader's uninstall guard now runs first on a type change, so the switch aborts on uncommitted or unpushed work instead of deleting it.Fixes #11567