Fix regression in startup performance when many scripts are defined and heavy classmaps are in use#12832
Merged
Merged
Conversation
…nd heavy classmaps are in use Fixes composer#12829
Contributor
|
might be worth adding a phpbench test-case to prevent regressions |
Member
Author
|
Yeah maybe. but it's just very hard to bench stuff as this one was dependent on many compounding factors to trigger the issue.. The obvious problems we notice them quickly. So I doubt this would really save us. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12829