Fix partial updates failing when a locked package has security advisories #12626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naderman
reviewed
Nov 19, 2025
| $packagesForAdvisories = []; | ||
| foreach ($pool->getPackages() as $package) { | ||
| if (!$package instanceof RootPackageInterface && !PlatformRepository::isPlatformPackage($package->getName())) { | ||
| if (!$package instanceof RootPackageInterface && !PlatformRepository::isPlatformPackage($package->getName()) && !$request->isLockedPackage($package)) { |
Member
There was a problem hiding this comment.
I'm not sure this is right. Now any locked package may remain? Shouldn't the packages marked for an update and if dependencies included, its dependencies be excluded here?
Member
There was a problem hiding this comment.
Will push a test for what I mean I guess
Member
Author
There was a problem hiding this comment.
When the PoolBuilder unlocks a package for update it also unlocks it in the Request, so my assumption was that this will just work, but feel free to add a test :)
Member
There was a problem hiding this comment.
Yup sorry you are right, just getting mixed up with the ordering of filter and pool builder. Added a test and it passes.
naderman
approved these changes
Nov 19, 2025
naderman
force-pushed
the
fix_partial_update_security_blocking
branch
from
2f6bdaf to
eb3327a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12620