Reverting 86b4aa1 to fix path resolution for vendor/bin proxies #12601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Oh man.. That's a nasty one, sorry I missed it. Thanks for the fix |
Contributor
|
maybe we can somehow execute this code and run PHPStan on a resulting file, to make sure we catch issues in CI? |
Member
|
This is tricky because it's only PHP <8, it was just bad luck / sloppy review on my end IMO.. Not sure it's worth the effort of having PHPStan run on the output here. https://github.com/composer/composer/releases/tag/2.9.1 is available now. |
Contributor
BashUnit might be able to help with that ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes introduced in #12499 caused the path resolution to fail, giving the following error when trying to execute any of the vendor/bin files in composer 2.9.
The issue it that some lines further down, the class variable $realpath is actually used and now missing:
closes #12600