Installer: fix audit call #12579
Merged
Installer: fix audit call #12579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
reviewed
Oct 28, 2025
| $auditConfig = $this->config->get('audit'); | ||
|
|
||
| return $auditor->audit($this->io, $repoSet, $packages, $this->auditFormat, true, $auditConfig['ignore'] ?? [], $auditConfig['abandoned'] ?? Auditor::ABANDONED_FAIL, [], $auditConfig['ignore-abandoned'] ?? []) > 0 && $this->errorOnAudit ? self::ERROR_AUDIT_FAILED : 0; | ||
| return $auditor->audit($this->io, $repoSet, $packages, $this->auditFormat, true, $auditConfig['ignore'] ?? [], $auditConfig['abandoned'] ?? Auditor::ABANDONED_FAIL, [], false, $auditConfig['ignore-abandoned'] ?? []) > 0 && $this->errorOnAudit ? self::ERROR_AUDIT_FAILED : 0; |
Contributor
There was a problem hiding this comment.
I wonder why this error was not detected by PHPStan. does this file miss PHPStan analysis?
Contributor
Author
There was a problem hiding this comment.
PHPStan thinks that
\PHPStan\dumpType($auditConfig['ignore-abandoned'] ?? []);
is
------ ----------------------------
Line src/Composer/Installer.php
------ ----------------------------
436 Dumped type: mixed~null
------ ----------------------------
Contributor
There was a problem hiding this comment.
ohh I see. too much mixed involved :).
maybe its worth narrowing the type of $auditConfig and/or its offsets
Contributor
Author
There was a problem hiding this comment.
Yes, there is a PR where an AuditConfig object is introduced https://github.com/composer/composer/pull/11956/files#diff-924136f376777a4a17917bc09fda283f8fc10226502c4ae81313d81d96398511R21
Member
|
Thanks and thanks @PhilETaylor for the quick report, definitely always good :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #12572 (comment)