-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Add update-with-minimal-changes config option #12545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
tests/Composer/Test/Fixtures/installer/full-update-minimal-changes-config.test
Outdated
Show resolved
Hide resolved
|
Thanks for the review @Seldaek! I've updated the config key name and json schema. Unfortunately, I had to remove the test as it was not working - I realized it doesn't actually test the command but rather the underlying installer so the config was not applied there. I think a bigger change would be needed to test such scenario. We could add an |
|
Yep to support this in tests you'd need to update https://github.com/composer/composer/blob/main/tests/Composer/Test/InstallerTest.php#L420 too. |
|
Let me try to pick it up as an improvement in a separate PR, if that's ok 🙏🏻 |
|
yeah please don't mix this in this PR for sure :D Not sure if much can be done about this.. I don't really mind it's not using the real command, because these .test files are about testing the Installer class and the solver internals in integration, the command class is irrelevant here. |
|
Thanks |
Resolves #12355
Adds
update-with-minimal-changesconfig option which can be set on both global and project level, allowing to minimize impact ofcomposer update.The test is exactly the same asfull-update-minimal-changes- simply added config entry there.