Use sudo.exe with self-update when available #12543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
serialization magic method has been deprecated. Implement __unserialize() instead (or in addition, if support for old PHP versions is necessary) |
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows the self-update command requires admin priviledges (if installed by ComposerSetup) and currently uses VBScript to invoke the UAC prompt.
However, VBScript deprecation was announced in 2023 and is slated to be disabled by default in 2027 (but available as an optional Windows feature). It may possibly be removed forever at some time after that.
Sudo for Windows is a recent solution to do the same thing but is currently only available behind a Developer setting.
This PR will use sudo if it is available, falling back to using VBScript. If this is not available I would imagine that the OS will output a message explaining why, as it does if you call sudo without enabling it.
https://learn.microsoft.com/en-us/windows/advanced-settings/sudo/
https://techcommunity.microsoft.com/blog/windows-itpro-blog/vbscript-deprecation-timelines-and-next-steps/4148301