fixes a regression introduced via 304107d breaking bumping versions containing a zero #12512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
verfriemelt-dot-org
changed the title
verfriemelt-dot-org
changed the title
the preg_match updated and broke support for major versions containing a zero :) like ~2025.1.x this should do the trick now.
verfriemelt-dot-org
force-pushed
the
fix-bump-with-zeros-in-versionnumber
branch
from
08f432c to
c962164
Compare
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the preg match was not updated to support major versions containing a zero :) like ~2025.1.x this should do the trick now. checkout the testcase for a proper example