fix: deprecation of curl_close in CurlDownloader.php #12505
Merged
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
approved these changes
Aug 19, 2025
Member
|
Thanks for the PR, could you please rebase it on the 2.8 branch tho so we can ship it in the next patch release (which will happen quicker)? |
stof
reviewed
Aug 20, 2025
jorgsowa
force-pushed
the
fix/curl-close-deprecation
branch
from
0591f4a to
f7839e3
Compare
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
curl_close()doesn't have any effect since PHP 8.0: https://www.php.net/manual/en/function.curl-close.phpThe deprecation of the function is implemented in PHP 8.5.