ProcessExecutor: mask GitHub fine grained access tokens similar to URL #12487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Yes feel free to extract in a const on the Util\GitHub class perhaps.. And please rebase on 2.8 as it should be in there I'd say. |
glaubinix
force-pushed
the
process-executor-hide-github-pat-tokens
branch
from
78a61ee to
9867df7
Compare
glaubinix
force-pushed
the
process-executor-hide-github-pat-tokens
branch
from
9867df7 to
af98a9e
Compare
Contributor
Author
|
Done and done. |
Member
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to 90673e4 wondering if the regex should be extracted into a const or similar to easier keep it in sync between the two components.