feat: Added --ignore-unreachable flag to audit command for private/unreachable repositories #12470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reachable repositories.
Contributor
Author
|
I'm not sure why phpstan failed, it ran fine on my side: https://github.com/i-web/composer/actions/runs/16144638585/job/45560116487 |
Contributor
|
This implementation is ignoring all repositories when one of them is unreachable instead of ignoring only the unreachable one. |
Contributor
Author
|
@stof Thank you for catching this. I have corrected it and tested it with several of my repos now (not only the ones where the protected package is the last in the list...) |
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #12467 this adds the option
--ignore-unreachablewhich will let the audit command run even if repositories are unreachable. They will be listed as unreachable in the report.No change has been made to the overall error handling.