-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Add driver to support forgejo/codeberge repositories #12307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7cc64e6 to
aeb4800
Compare
aeb4800 to
b3f3f71
Compare
225adb5 to
a84121c
Compare
src/Composer/Util/ForgejoUrl.php
Outdated
| ); | ||
| } | ||
|
|
||
| public function generateSshUr(): string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| public function generateSshUr(): string | |
| public function generateSshUrl(): string |
|
LGTM, just would be nice to rebase it and fix that typo then if build is green let's merge! |
fbc6b43 to
cc65565
Compare
|
|
||
| /** | ||
| * Returns whether or not the given $identifier should be cached or not. | ||
| * @phpstan-assert-if-true !null $this->cache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Seldaek I needed this change to prevent another PHPStan issue. Which then force me to add the string cast after all the json_encode calls in the driver when writing to the cache.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, fixed to avoid hiding errors in 1287062
…not hide json errors
7b5b028 to
1287062
Compare
Implements: #12267
Includes:
Note: I had to make a change to the
VcsDriverto address a PHPStan issue. This now surfaced more PHPStan issues. Happy to address, ignore or baseline them.Sample composer.json