Skip to content

Conversation

@glaubinix
Copy link
Contributor

Implements: #12267

Includes:

  • basic driver
  • config options to define domains and tokens
  • minimalistic error handling in case there is no access token configured

Note: I had to make a change to the VcsDriver to address a PHPStan issue. This now surfaced more PHPStan issues. Happy to address, ignore or baseline them.

Sample composer.json

{
    "name": "acme/project",
    "version": "1.0",
    "repositories": [
        {"type": "vcs", "url":  "https://codeberg.org/glaubinix-acme/acme"}
    ],
    "require": {
        "glaubinix-acme/acme": "1.0"
    }
}

@Seldaek Seldaek added this to the 2.9 milestone Feb 18, 2025
@glaubinix glaubinix force-pushed the forgejo-support branch 2 times, most recently from 7cc64e6 to aeb4800 Compare February 24, 2025 13:12
);
}

public function generateSshUr(): string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public function generateSshUr(): string
public function generateSshUrl(): string

@Seldaek
Copy link
Member

Seldaek commented Oct 7, 2025

LGTM, just would be nice to rebase it and fix that typo then if build is green let's merge!


/**
* Returns whether or not the given $identifier should be cached or not.
* @phpstan-assert-if-true !null $this->cache
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Seldaek I needed this change to prevent another PHPStan issue. Which then force me to add the string cast after all the json_encode calls in the driver when writing to the cache.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, fixed to avoid hiding errors in 1287062

@Seldaek Seldaek merged commit 1c9cd04 into composer:main Oct 28, 2025
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants