Add support for ignoring the upper bound of platform requirements using "name+" notation #10318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seldaek
force-pushed
the
ignore_upper_bounds
branch
2 times, most recently
from
e49fa7b to
2b80b14
Compare
|
Thank you for working on this feature! |
|
Hehe, I had a similar idea. Really glad to see that the ignore platform reqs refactoring was helpful :) |
Seldaek
force-pushed
the
ignore_upper_bounds
branch
from
2b80b14 to
b89f7be
Compare
|
@herndlm yeah this definitely enabled a much easier implementation for this use case. |
Seldaek
force-pushed
the
ignore_upper_bounds
branch
from
b89f7be to
c29251a
Compare
naderman
requested changes
Dec 6, 2021
src/Composer/Filter/PlatformRequirementFilter/IgnoreListPlatformRequirementFilter.php
Show resolved
Hide resolved
...er/Test/Fixtures/installer/update-ignore-platform-package-requirement-list-upper-bounds.test
Show resolved
Hide resolved
naderman
reviewed
Dec 6, 2021
...er/Test/Fixtures/installer/update-ignore-platform-package-requirement-list-upper-bounds.test
Outdated
Show resolved
Hide resolved
Seldaek
force-pushed
the
ignore_upper_bounds
branch
from
7586749 to
ff04836
Compare
naderman
reviewed
Dec 7, 2021
naderman
reviewed
Dec 7, 2021
...er/Test/Fixtures/installer/update-ignore-platform-package-requirement-list-upper-bounds.test
Outdated
Show resolved
Hide resolved
Seldaek
force-pushed
the
ignore_upper_bounds
branch
from
ff04836 to
637feab
Compare
…ng "name+" notation
…hich are not really loaded in general
Seldaek
force-pushed
the
ignore_upper_bounds
branch
from
637feab to
ca5d5b4
Compare
derickr
reviewed
Dec 15, 2021
| does not fulfill it. Multiple requirements can be ignored via wildcard. Appending | ||
| a `+` makes it only ignore the upper-bound of the requirements. For example, if a package | ||
| requires `php: ^7`, then the option `--ignore-platform-req=php+` would allow installing on PHP8, | ||
| but installation on PHP 5.6 would still fail. |
There was a problem hiding this comment.
So it's PHP 5.6, but then PHP8. There is a space missing there ;-)
|
It seems to unnecessarily print the error message |
|
@dg Yeah that warning is handled somewhere else, please open a new issue with details how to repro. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.g.
--ignore-platform-req=php+ignores the upper bound of the php requirements.Fixes #9534