-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wildcard support to ignore platform req #10083
Add wildcard support to ignore platform req #10083
Conversation
As #10079 is not merged yet this PR contains that PR's commit too. After it got merged this one needs to be re-targeted. |
src/Composer/Filter/PlatformRequirementFilter/IgnoreListPlatformRequirementFilter.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM now, will need a rebase once the other PR is merged but I can do that myself when branching out 2.2 if needed :)
9a51544
to
943db45
Compare
Great, I could not resist cleaning up the fixup commits, I'll leave the rest to you now, except you need me to resolve merge conflicts or so :) Btw unrelated, but if you need help in increasing the phpstan level or cleanup some more code for phpstan by adding/fixing types and so on, feel free to create issues for that or ping me. I would gladly help out, but will not touch too much if you're also working on it |
943db45
to
70e337a
Compare
Also: I had to remove the static keyword in the anonymous function in |
Yeah that would be great, I have been working on typing all properties already, because that gives a good foundation to then type method return values and parameters, which will then force more typing in various places to fix usage warnings surely. I'm almost done with properties, then maybe I can create an issue with some instructions how to run this and what would be the most valuable, but I'm not entirely sure how much is worth doing right now and how much would be best to wait for us to drop old PHP then we can add proper scalar types instead of adding docblocks now and having to migrate them in a few months. So yeah happy to get help at some point but probably it's too soon :) |
70e337a
to
7a2cf5f
Compare
rebased to fix a conflict |
We can automate this step with rector |
7a2cf5f
to
d2ad193
Compare
d2ad193
to
439a974
Compare
rebased to fix a conflict |
As promised in #10083 (comment) - here is #10159 if you still want to help @herndlm (or anyone:) |
439a974
to
0e93ff9
Compare
rebased after the precondition was merged 🎉 |
Thanks! |
This is the implementation of what is described in #10045 and the follow-up of #10079.