Added --no-optimizer flag to composer update

Toflar · Toflar · commit 96dcbc9fc2cd · 2020-10-12T12:10:03.000+02:00
diff --git a/doc/03-cli.md b/doc/03-cli.md
@@ -181,6 +181,7 @@ php composer.phar update vendor/package:2.0.1 vendor/package2:3.0.*
 * **--no-scripts:** Skips execution of scripts defined in `composer.json`.
 * **--no-progress:** Removes the progress display that can mess with some
   terminals or scripts which don't handle backspace characters.
+* **--no-optimizer:** Disables the [pool optimizer](articles/troubleshooting.md#pool-optimizer).
 * **--with-dependencies (-w):** Update also dependencies of packages in the argument list, except those which are root requirements.
 * **--with-all-dependencies (-W):** Update also dependencies of packages in the argument list, including those which are root requirements.
 * **--optimize-autoloader (-o):** Convert PSR-0/4 autoloading to classmap to get a faster
diff --git a/doc/articles/troubleshooting.md b/doc/articles/troubleshooting.md
@@ -320,3 +320,28 @@ Composer can unpack zipballs using either a system-provided `unzip` utility or P
 native `ZipArchive` class. The `ZipArchive` class is preferred on Windows. On other
 OSes where ZIP files can contain permissions and symlinks, the `unzip` utility is
 preferred. You're advised to install it if you need these features.
+
+## Pool Optimizer
+
+In Composer, the `Pool` contains all the packages that are relevant for the dependency
+resolving process. Ultimately, that's what is used to generate all the rules which are then
+passed on to the dependency solver internally.
+In order to improve performance, Composer tries to optimize this `Pool` by removing useless
+package information early on.
+
+If all goes well, you should never notice any issues with it but in case you run into
+an unexpected result such as an unresolvable set of dependencies or conflicts where you
+think Composer is wrong, you might want to disable the optimizer by running
+
+```bash
+composer update --no-optimizer
+```
+
+and see, if the result is still the same. It will take significantly longer and use
+a lot more memory to run the dependency resolving process.
+
+If the result is different, you likely hit a problem in the Pool Optimizer.
+Please report this [issue](https://github.com/composer/composer/issues) so it can be fixed.
+
+
+
diff --git a/src/Composer/Command/UpdateCommand.php b/src/Composer/Command/UpdateCommand.php
@@ -54,6 +54,7 @@ protected function configure()
                 new InputOption('no-scripts', null, InputOption::VALUE_NONE, 'Skips the execution of all scripts defined in composer.json file.'),
                 new InputOption('no-suggest', null, InputOption::VALUE_NONE, 'DEPRECATED: This flag does not exist anymore.'),
                 new InputOption('no-progress', null, InputOption::VALUE_NONE, 'Do not output download progress.'),
+                new InputOption('no-optimizer', null, InputOption::VALUE_NONE, 'Disables the pool optimizer.'),
                 new InputOption('with-dependencies', 'w', InputOption::VALUE_NONE, 'Update also dependencies of packages in the argument list, except those which are root requirements.'),
                 new InputOption('with-all-dependencies', 'W', InputOption::VALUE_NONE, 'Update also dependencies of packages in the argument list, including those which are root requirements.'),
                 new InputOption('verbose', 'v|vv|vvv', InputOption::VALUE_NONE, 'Shows more details including new commits pulled in when updating packages.'),
@@ -225,6 +226,10 @@ protected function execute(InputInterface $input, OutputInterface $output)
             $install->disablePlugins();
         }
 
+        if ($input->getOption('no-optimizer')) {
+            $install->disablePoolOptimizer();
+        }
+
         return $install->run();
     }
 
diff --git a/src/Composer/Installer.php b/src/Composer/Installer.php
@@ -139,6 +139,7 @@ class Installer
     protected $preferLowest = false;
     protected $writeLock;
     protected $executeOperations = true;
+    protected $disablePoolOptimizer = false;
 
     /**
      * Array of package names/globs flagged for update
@@ -409,8 +410,7 @@ protected function doUpdate(RepositoryInterface $localRepo, $doInstall)
             $request->setUpdateAllowList($this->updateAllowList, $this->updateAllowTransitiveDependencies);
         }
 
-        $poolOptimizer = new PoolOptimizer($policy);
-        $pool = $repositorySet->createPool($request, $this->io, $this->eventDispatcher, $poolOptimizer);
+        $pool = $repositorySet->createPool($request, $this->io, $this->eventDispatcher, $this->createPoolOptimizer($policy));
 
         // solve dependencies
         $solver = new Solver($policy, $pool, $this->io);
@@ -641,8 +641,7 @@ protected function doInstall(RepositoryInterface $localRepo, $alreadySolved = fa
                 $request->requireName($link->getTarget(), $link->getConstraint());
             }
 
-            $poolOptimizer = new PoolOptimizer($policy);
-            $pool = $repositorySet->createPool($request, $this->io, $this->eventDispatcher, $poolOptimizer);
+            $pool = $repositorySet->createPool($request, $this->io, $this->eventDispatcher, $this->createPoolOptimizer($policy));
 
             // solve dependencies
             $solver = new Solver($policy, $pool, $this->io);
@@ -905,6 +904,18 @@ private function mockLocalRepositories(RepositoryManager $rm)
         );
     }
 
+    /**
+     * @return PoolOptimizer|null
+     */
+    private function createPoolOptimizer(PolicyInterface $policy)
+    {
+        if ($this->disablePoolOptimizer) {
+            return null;
+        }
+
+        return new PoolOptimizer($policy);
+    }
+
     /**
      * Create Installer
      *
@@ -1283,6 +1294,11 @@ public function disablePlugins()
         return $this;
     }
 
+    public function disablePoolOptimizer()
+    {
+        $this->disablePoolOptimizer = true;
+    }
+
     /**
      * @param  SuggestedPackagesReporter $suggestedPackagesReporter
      * @return Installer
