Fix Windows CI#300
Open
ncihnegn wants to merge 3 commits into
Open
Conversation
Collaborator
|
Personally I don't want to get in to the business of interpreting paths too much since it's already tricky enough. Stripping a leading |
Contributor
Author
|
Are you open to use a crate for |
Collaborator
|
I'm not personally familiar with any such crates, is there no way to do this using the standard library? |
Contributor
Author
|
I think using |
ncihnegn
force-pushed
the
windows
branch
2 times, most recently
from
80bc06f to
c0ffc46
Compare
Contributor
Author
|
Simplified a bit without using a crate; please review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix #299.