Skip to content

Preserve symlink mtimes#289

Merged
alexcrichton merged 1 commit into
composefs:masterfrom
jrwats:master
Apr 4, 2022
Merged

Preserve symlink mtimes#289
alexcrichton merged 1 commit into
composefs:masterfrom
jrwats:master

Conversation

@jrwats

@jrwats jrwats commented Apr 2, 2022

Copy link
Copy Markdown
Contributor

An archive with preserve_mtime = true should match the behavior of tar -vpxf ...

Addresses: #288

Comment thread tests/all.rs
assert!(md.file_type().is_symlink());

let mtime = FileTime::from_last_modification_time(&md);
assert_eq!(mtime.unix_seconds(), 1448291033);

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously this would have been "now"

@alexcrichton alexcrichton merged commit f4f439c into composefs:master Apr 4, 2022
facebook-github-bot pushed a commit to facebook/fb303 that referenced this pull request Aug 10, 2023
Summary:
Update includes [composefs/tar-rs#289], so we can unfork.

[composefs/tar-rs#289]: composefs/tar-rs#289

Reviewed By: diliop, shayne-fletcher

Differential Revision: D48230634

fbshipit-source-id: 2c3ff2ff01c8857f3f4e2e06b2688f739bcedb2c
facebook-github-bot pushed a commit to facebook/sapling that referenced this pull request Aug 10, 2023
Summary:
Update includes [composefs/tar-rs#289], so we can unfork.

[composefs/tar-rs#289]: composefs/tar-rs#289

Reviewed By: diliop, shayne-fletcher

Differential Revision: D48230634

fbshipit-source-id: 2c3ff2ff01c8857f3f4e2e06b2688f739bcedb2c
facebook-github-bot pushed a commit to facebookexperimental/rust-shed that referenced this pull request Aug 10, 2023
Summary:
Update includes [composefs/tar-rs#289], so we can unfork.

[composefs/tar-rs#289]: composefs/tar-rs#289

Reviewed By: diliop, shayne-fletcher

Differential Revision: D48230634

fbshipit-source-id: 2c3ff2ff01c8857f3f4e2e06b2688f739bcedb2c
facebook-github-bot pushed a commit to facebookincubator/below that referenced this pull request Aug 10, 2023
Summary:
Update includes [composefs/tar-rs#289], so we can unfork.

[composefs/tar-rs#289]: composefs/tar-rs#289

Reviewed By: diliop, shayne-fletcher

Differential Revision: D48230634

fbshipit-source-id: 2c3ff2ff01c8857f3f4e2e06b2688f739bcedb2c
charliermarsh added a commit to astral-sh/tokio-tar that referenced this pull request Feb 5, 2025
## Summary

Ports composefs/tar-rs#289 to `async-tar`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants