Skip to content

Readd support for device_cgroup_rules#63

Merged
ndeloof merged 1 commit intocompose-spec:masterfrom
agners:add-device-cgroup-rules
May 14, 2020
Merged

Readd support for device_cgroup_rules#63
ndeloof merged 1 commit intocompose-spec:masterfrom
agners:add-device-cgroup-rules

Conversation

@agners
Copy link
Copy Markdown
Contributor

@agners agners commented Apr 21, 2020

This readds support for device_cgroup_rules which was present in
compose file format 2.4.

Signed-off-by: Stefan Agner [email protected]

What this PR does / why we need it:
Readd the device_cgroup_rules property which was present in Compose 2.3. It will allow to use Compose files which enable devices selectively via cgroup rules.

Which issue(s) this PR fixes:
Fixes #62

Copy link
Copy Markdown
Collaborator

@ndeloof ndeloof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subject to approval of the general idea exposed by #12

You also will have to provide field description in spec.md

@ndeloof ndeloof mentioned this pull request Apr 22, 2020
@agners agners force-pushed the add-device-cgroup-rules branch from c939944 to eb64a9e Compare April 23, 2020 07:40
@agners
Copy link
Copy Markdown
Contributor Author

agners commented Apr 23, 2020

@ndeloof added a description to spec.md.

@agners agners force-pushed the add-device-cgroup-rules branch 2 times, most recently from 752e72a to 3522ada Compare April 23, 2020 07:43
@agners
Copy link
Copy Markdown
Contributor Author

agners commented Apr 29, 2020

@ndeloof I guess this is ready to be merged then?

@ndeloof
Copy link
Copy Markdown
Collaborator

ndeloof commented May 14, 2020

@agners can you please rebase to fix conflicts, then I'll merge this one

This readds support for `device_cgroup_rules` which was present in
compose file format 2.4.

Signed-off-by: Stefan Agner <[email protected]>
@agners agners force-pushed the add-device-cgroup-rules branch from 3522ada to c4ae76d Compare May 14, 2020 07:01
@agners
Copy link
Copy Markdown
Contributor Author

agners commented May 14, 2020

@ndeloof rebased!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for device_cgroup_rules

3 participants