Add regex format restriction for container_name#60
Merged
Conversation
ndeloof
approved these changes
Apr 14, 2020
hangyan
force-pushed
the
container-name-regex
branch
from
April 14, 2020 08:06
85aeaf6 to
78a3bac
Compare
Signed-off-by: Hang Yan <[email protected]>
hangyan
force-pushed
the
container-name-regex
branch
from
April 19, 2020 12:57
78a3bac to
bc6ed3d
Compare
| Compose implementation MUST NOT scale a service beyond one container if the Compose file specifies a | ||
| `container_name`. Attempting to do so MUST result in an error. | ||
|
|
||
| If represents, `container_name` SHOULD follow the regex fomrat of `[a-zA-Z0-9][a-zA-Z0-9_.-]+` |
ndeloof
approved these changes
Jun 5, 2020
chris-crone
approved these changes
Jun 5, 2020
chris-crone
left a comment
chris-crone
left a comment
Contributor
There was a problem hiding this comment.
LGTM but we should fix the typo mentioned above. Can do so in a followup.
Signed-off-by: Eric Hripko <[email protected]>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Hang Yan [email protected]
What this PR does / why we need it:
Add regex name restriction fort container_name feld.
Which issue(s) this PR fixes:
Fixes #34
Seems this regex restrictions does not appear in the runtime spec, and it's reported by this issue
moby/moby#3138. Accounding the comments, this regex also apply for users and images, so i think it's fair enough to add this restirctions. As for kubernetes, it can easily use some transform methods to fit in this restriction.