Add a network-scoped mac_address field#435
Merged
glours merged 1 commit intocompose-spec:masterfrom Nov 20, 2023
Merged
Conversation
akerouanton
changed the title
akerouanton
added a commit
to akerouanton/compose-go
that referenced
this pull request
Nov 20, 2023
Related to: - moby/moby#45905 - compose-spec/compose-spec#435 Signed-off-by: Albin Kerouanton <[email protected]>
glours
requested changes
Nov 20, 2023
05-services.md
Outdated
| ### mac_address | ||
|
|
||
| `mac_address` sets a MAC address for the service container. | ||
| _DEPRECATED: use [networks.mac_address](#mac_address)_ |
Contributor
There was a problem hiding this comment.
We can't mark it as deprecated if it's not also deprecated on the Docker CLI either
Contributor
|
You also need to update the |
akerouanton
force-pushed
the
endpoint-specific-mac-address
branch
from
87768b6 to
5a74beb
Compare
akerouanton
added a commit
to akerouanton/compose-go
that referenced
this pull request
Nov 20, 2023
Related to: - moby/moby#45905 - compose-spec/compose-spec#435 Signed-off-by: Albin Kerouanton <[email protected]>
ndeloof
approved these changes
Nov 20, 2023
Contributor
|
@akerouanton I forgot to mention, you need to run |
glours
approved these changes
Nov 20, 2023
akerouanton
force-pushed
the
endpoint-specific-mac-address
branch
from
5a74beb to
e4ad97d
Compare
Contributor
Author
|
@glours should be good now. |
glours
force-pushed
the
endpoint-specific-mac-address
branch
from
e4ad97d to
0b51ba1
Compare
Since moby/moby#45905 has been merged (will be part of the upcoming v25 release), it's now possible to specify an endpoint-specific MAC address. Moreover, setting the container-wide MAC address will return a warning. Signed-off-by: Albin Kerouanton <[email protected]>
akerouanton
force-pushed
the
endpoint-specific-mac-address
branch
from
0b51ba1 to
d1e8613
Compare
akerouanton
added a commit
to akerouanton/compose-go
that referenced
this pull request
Nov 20, 2023
Related to: - compose-spec/compose-spec#435 Signed-off-by: Albin Kerouanton <[email protected]>
akerouanton
added a commit
to akerouanton/compose-go
that referenced
this pull request
Nov 20, 2023
Related to: - compose-spec/compose-spec#435 Signed-off-by: Albin Kerouanton <[email protected]> (cherry picked from commit 0282c0c) Signed-off-by: Albin Kerouanton <[email protected]>
akerouanton
added a commit
to akerouanton/compose
that referenced
this pull request
Nov 20, 2023
Related to: - compose-spec/compose-spec#435 - moby/moby#45905 Since API v1.44, Moby supports a per-endpoint MAC address and returns a warning when the container-wide mac_address field is set. A corresponding field has been added to compose-spec and compose-go, so we need to leverage it to set the right API field. This commit is backward-compatible with compose files that still set the container-wide mac_address field, and older API versions that don't know about the endpoint-specific MAC address field. Signed-off-by: Albin Kerouanton <[email protected]>
akerouanton
added a commit
to akerouanton/compose
that referenced
this pull request
Nov 20, 2023
Related to: - compose-spec/compose-spec#435 - moby/moby#45905 Since API v1.44, Moby supports a per-endpoint MAC address and returns a warning when the container-wide mac_address field is set. A corresponding field has been added to compose-spec and compose-go, so we need to leverage it to set the right API field. This commit is backward-compatible with compose files that still set the container-wide mac_address field, and older API versions that don't know about the endpoint-specific MAC address field. Signed-off-by: Albin Kerouanton <[email protected]>
akerouanton
added a commit
to akerouanton/compose
that referenced
this pull request
Nov 21, 2023
Related to: - compose-spec/compose-spec#435 - moby/moby#45905 Since API v1.44, Moby supports a per-endpoint MAC address and returns a warning when the container-wide mac_address field is set. A corresponding field has been added to compose-spec and compose-go, so we need to leverage it to set the right API field. This commit is backward-compatible with compose files that still set the container-wide mac_address field, and older API versions that don't know about the endpoint-specific MAC address field. Signed-off-by: Albin Kerouanton <[email protected]>
akerouanton
added a commit
to akerouanton/compose
that referenced
this pull request
Nov 21, 2023
Related to: - compose-spec/compose-spec#435 - moby/moby#45905 Since API v1.44, Moby supports a per-endpoint MAC address and returns a warning when the container-wide mac_address field is set. A corresponding field has been added to compose-spec and compose-go, so we need to leverage it to set the right API field. This commit is backward-compatible with compose files that still set the container-wide mac_address field, and older API versions that don't know about the endpoint-specific MAC address field. Signed-off-by: Albin Kerouanton <[email protected]>
akerouanton
added a commit
to akerouanton/compose
that referenced
this pull request
Nov 21, 2023
Related to: - compose-spec/compose-spec#435 - moby/moby#45905 Since API v1.44, Moby supports a per-endpoint MAC address and returns a warning when the container-wide mac_address field is set. A corresponding field has been added to compose-spec and compose-go, so we need to leverage it to set the right API field. This commit is backward-compatible with compose files that still set the container-wide mac_address field, and older API versions that don't know about the endpoint-specific MAC address field. Signed-off-by: Albin Kerouanton <[email protected]>
glours
pushed a commit
to akerouanton/compose-go
that referenced
this pull request
Nov 21, 2023
Related to: - compose-spec/compose-spec#435 Signed-off-by: Albin Kerouanton <[email protected]> (cherry picked from commit 0282c0c) Signed-off-by: Albin Kerouanton <[email protected]>
glours
pushed a commit
to compose-spec/compose-go
that referenced
this pull request
Nov 21, 2023
Related to: - compose-spec/compose-spec#435 Signed-off-by: Albin Kerouanton <[email protected]> (cherry picked from commit 0282c0c) Signed-off-by: Albin Kerouanton <[email protected]>
akerouanton
added a commit
to akerouanton/compose
that referenced
this pull request
Dec 18, 2023
Related to: - compose-spec/compose-spec#435 - moby/moby#45905 Since API v1.44, Moby supports a per-endpoint MAC address and returns a warning when the container-wide mac_address field is set. A corresponding field has been added to compose-spec and compose-go, so we need to leverage it to set the right API field. This commit is backward-compatible with compose files that still set the container-wide mac_address field, and older API versions that don't know about the endpoint-specific MAC address field. Signed-off-by: Albin Kerouanton <[email protected]>
ndeloof
pushed a commit
to docker/compose
that referenced
this pull request
Dec 18, 2023
Related to: - compose-spec/compose-spec#435 - moby/moby#45905 Since API v1.44, Moby supports a per-endpoint MAC address and returns a warning when the container-wide mac_address field is set. A corresponding field has been added to compose-spec and compose-go, so we need to leverage it to set the right API field. This commit is backward-compatible with compose files that still set the container-wide mac_address field, and older API versions that don't know about the endpoint-specific MAC address field. Signed-off-by: Albin Kerouanton <[email protected]>
temenuzhka-thede
pushed a commit
to temenuzhka-thede/compose
that referenced
this pull request
Sep 17, 2024
Related to: - compose-spec/compose-spec#435 - moby/moby#45905 Since API v1.44, Moby supports a per-endpoint MAC address and returns a warning when the container-wide mac_address field is set. A corresponding field has been added to compose-spec and compose-go, so we need to leverage it to set the right API field. This commit is backward-compatible with compose files that still set the container-wide mac_address field, and older API versions that don't know about the endpoint-specific MAC address field. Signed-off-by: Albin Kerouanton <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add a network-scoped mac_address field
Since moby/moby#45905 has been merged (will be part of the upcoming v25 release), it's now possible to specify an endpoint-specific MAC address. Moreover, setting the container-wide MAC address will return a warning.
Deprecate container-wide MAC address