introduce inline content for configs#429
Conversation
b94210c to
946c3ab
Compare
glours
left a comment
There was a problem hiding this comment.
Just as nit to make things clearer
08-configs.md
Outdated
| The top-level `configs` declaration defines or references configuration data that is granted to services in your Compose application. The source of the config is either `file` or `external`. | ||
|
|
||
| - `file`: The config is created with the contents of the file at the specified path. | ||
| - `environment`: The config is created with the value of an environment variable. |
There was a problem hiding this comment.
| - `environment`: The config is created with the value of an environment variable. | |
| - `environment`: The config content is created with the value of an environment variable. |
946c3ab to
e2ad297
Compare
Signed-off-by: Nicolas De Loof <[email protected]>
e2ad297 to
bb9ba94
Compare
|
How does one benefit from this change? With the latest Docker Desktop 4.25.2 (129061), I get |
I also tried this since it's published on the docs ( I looked through the release notes and found nothing (not too fun with fairly generic keywords Then I tried to track down the source from the docs:
That was a bit of a mission 😅 Didn't realize the feature was that new. I'm on v2.21.0 (Aug 30th). I was on 4.23.0 (120376), but now also upgraded to the latest version is 4.25.2 (129061), but unfortunately that's not new enough 😆 TL;DR
Docker Desktop 4.25.0 (released Oct 26th) provides Docker Compose 2.23.0 ( While 4.25.2 (Nov 21st) probably could have bumped the compose version, we'll probably have to wait a little bit longer for a new release to handle that. |
|
I would like to suggest upgrading compose specification version for changes like this one. Just now I've ran into this situation:
That is confusing. |
This is exactly what "complain about incompatibility" is about. Maybe we should add "please upgrade docker compose" to this message. |
|
Unfortunately, there is no way to distinguish between "please upgrade docker compose" and "you mistyped a keyword or used it on incorrect nesting level".
That is sad 😢 Look at terraform and terraform providers, for example. Each version explicitly has it's own specification. As long as you follow that specification for selected version - you will not run into compatibility issues. |
What this PR does / why we need it:
Introduce support for inlined content when defining a configuration file
Which issue(s) this PR fixes:
Fixes #346