add a 'restart' action to watch attribute in the develop section#423
Merged
glours merged 1 commit intocompose-spec:masterfrom Oct 17, 2023
Merged
add a 'restart' action to watch attribute in the develop section#423glours merged 1 commit intocompose-spec:masterfrom
glours merged 1 commit intocompose-spec:masterfrom
Conversation
glours
requested review from
EricHripko,
aevesdocker,
laurazard,
milas,
ndeloof and
ulyssessouza
aevesdocker
reviewed
Oct 12, 2023
aevesdocker
reviewed
Oct 12, 2023
develop.md
Outdated
| - `rebuild`, Compose rebuilds the service image based on the `build` section and recreates the service with the updated image. | ||
| - `sync`, Compose keeps the existing service container(s) running, but synchronizes source files with container content according to the `target` attribute. | ||
| - `sync`, Compose keeps the existing service container(s) running, but synchronizes source files with container content according to the `target` attribute. | ||
| - `restart`, Compose synchronizes source files with container content according to the `target` attribute. and then restarts the container. |
Contributor
There was a problem hiding this comment.
Suggested change
| - `restart`, Compose synchronizes source files with container content according to the `target` attribute. and then restarts the container. | |
| - `restart`, Compose synchronizes source files with container content according to the `target` attribute, and then restarts the container. |
Wrong button..
Collaborator
There was a problem hiding this comment.
I wonder restart actually also does a sync, and at some point we might want to introduce support for some "restart-only" action. So I'd suggest we introduce a more explicit sync+restart action - or any better notation, be creative ;)
Contributor
Author
There was a problem hiding this comment.
I'm fine with this option let's do that 👍
Contributor
Author
There was a problem hiding this comment.
Done! Thanks to both of you 🤗
ndeloof
approved these changes
Oct 12, 2023
develop.md
Outdated
| - `rebuild`, Compose rebuilds the service image based on the `build` section and recreates the service with the updated image. | ||
| - `sync`, Compose keeps the existing service container(s) running, but synchronizes source files with container content according to the `target` attribute. | ||
| - `sync`, Compose keeps the existing service container(s) running, but synchronizes source files with container content according to the `target` attribute. | ||
| - `restart`, Compose synchronizes source files with container content according to the `target` attribute. and then restarts the container. |
Collaborator
There was a problem hiding this comment.
I wonder restart actually also does a sync, and at some point we might want to introduce support for some "restart-only" action. So I'd suggest we introduce a more explicit sync+restart action - or any better notation, be creative ;)
aevesdocker
approved these changes
Oct 12, 2023
Signed-off-by: Guillaume Lours <[email protected]>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add a new action
restartto thewatchattribute of the develop section.This action will first sync files and the restart the container.
Which issue(s) this PR fixes:
Fixes docker/compose#11062