Add start_interval to healthcheck#383
Merged
glours merged 1 commit intocompose-spec:masterfrom Jul 13, 2023
Merged
Conversation
glours
approved these changes
Jul 6, 2023
12 tasks
Member
|
It's finally here 🎉 ! I'm just looking at this from my phone, but I wonder if we need changes to the schema json (somewhere around compose-spec/schema/compose-spec.json Line 460 in ec66400 |
Contributor
|
You're right @laurazard 👍 , we need to update |
Member
|
@cpuguy83 can you take care of that or should one of us make some quick changes? |
cpuguy83
force-pushed
the
health-start-interval
branch
from
af2645f to
760feb3
Compare
Start interval is the interval that healthchecks are performed during the start period. Signed-off-by: Brian Goff <[email protected]>
cpuguy83
force-pushed
the
health-start-interval
branch
from
760feb3 to
720ae3e
Compare
Contributor
Author
|
Updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Start interval is the interval that healthchecks are performed during the start period.
This was added in moby in moby/moby#40894.
You can see the linked issue in that PR for the number of users asking for this.
Docker CLI changes: docker/cli#4405
Swarmkit changes: moby/swarmkit#3142