add required attribute depends_on#382
Merged
ndeloof merged 1 commit intocompose-spec:masterfrom Jul 6, 2023
Merged
Conversation
glours
requested review from
EricHripko,
laurazard,
milas,
ndeloof and
ulyssessouza
glours
force-pushed
the
depends_on-required-attribut
branch
from
3b052dd to
b6dd189
Compare
ndeloof
approved these changes
Jul 4, 2023
glours
force-pushed
the
depends_on-required-attribut
branch
2 times, most recently
from
0539ac1 to
db30100
Compare
laurazard
approved these changes
Jul 5, 2023
| service. | ||
| - `service_completed_successfully`: specifies that a dependency is expected to run | ||
| to successful completion before starting a dependent service. | ||
| - `required`: when `false` Compose only warns you when the dependency service isn't started or available. If not defined |
Member
There was a problem hiding this comment.
Nit: maybe an empty line such as in 374 to separate the new field description more from the rest?
Signed-off-by: Guillaume Lours <[email protected]>
ndeloof
force-pushed
the
depends_on-required-attribut
branch
from
db30100 to
6054385
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Introduce a
requiredattribut todepends_onto allow a Compose implementation to only warn user when a dependency service isn't started or available.Why this change?
Since the beginning the reference implementation Docker Compose was silently ignore missing dependency services, recently a fix was introduced to strictly follow the specification and broke existing users Compose configurations.
Adding this new attribute will let them continue to use the previous behaviour while making clear and explicit the
depends_oncould be bypass by the Compose implementationWhich issue(s) this PR fixes:
Fixes #274