Introduce profiles for services#110
Merged
Merged
Conversation
acran
marked this pull request as draft
October 21, 2020 20:22
acran
marked this pull request as ready for review
October 21, 2020 20:24
Closed
ndeloof
approved these changes
Oct 22, 2020
EricHripko
reviewed
Oct 23, 2020
EricHripko
left a comment
EricHripko
left a comment
Collaborator
There was a problem hiding this comment.
Looks like an awesome start 🙌 I've left a few comments inline 💬
Contributor
Author
|
I updated the PR with @EricHripko comments and added/clarified some examples. |
Contributor
Author
|
So, any further comments on the updated PR, or can this be moved forward? |
EricHripko
reviewed
Nov 3, 2020
EricHripko
left a comment
EricHripko
left a comment
Collaborator
There was a problem hiding this comment.
2 minor wording suggestions - otherwise this looks good to go 🙌
implements compose-spec#97 also solves compose-spec#87 Signed-off-by: Roman Anasal <[email protected]>
Contributor
Author
|
Thanks @EricHripko |
EricHripko
approved these changes
Nov 5, 2020
EricHripko
left a comment
EricHripko
left a comment
Collaborator
There was a problem hiding this comment.
Looks great ✅ Thank you for picking up and finishing the initial draft of this proposal 👍
acran
added a commit
to acran/compose
that referenced
this pull request
Nov 15, 2020
Implement profiles as introduced in compose-spec/compose-spec#110 fixes docker#7919 closes docker#1896 closes docker#6742 closes docker#7539
acran
added a commit
to acran/compose
that referenced
this pull request
Nov 15, 2020
Implement profiles as introduced in compose-spec/compose-spec#110 fixes docker#7919 closes docker#1896 closes docker#6742 closes docker#7539 Signed-off-by: Roman Anasal <[email protected]>
acran
added a commit
to acran/compose
that referenced
this pull request
Nov 16, 2020
Implement profiles as introduced in compose-spec/compose-spec#110 fixes docker#7919 closes docker#1896 closes docker#6742 closes docker#7539 Signed-off-by: Roman Anasal <[email protected]>
acran
added a commit
to acran/compose
that referenced
this pull request
Nov 30, 2020
Implement profiles as introduced in compose-spec/compose-spec#110 fixes docker#7919 closes docker#1896 closes docker#6742 closes docker#7539 Signed-off-by: Roman Anasal <[email protected]>
acran
added a commit
to acran/compose
that referenced
this pull request
Dec 1, 2020
Implement profiles as introduced in compose-spec/compose-spec#110 fixes docker#7919 closes docker#1896 closes docker#6742 closes docker#7539 Signed-off-by: Roman Anasal <[email protected]>
acran
added a commit
to acran/compose
that referenced
this pull request
Dec 1, 2020
Implement profiles as introduced in compose-spec/compose-spec#110 fixes docker#7919 closes docker#1896 closes docker#6742 closes docker#7539 Signed-off-by: Roman Anasal <[email protected]>
acran
added a commit
to acran/compose
that referenced
this pull request
Dec 2, 2020
Implement profiles as introduced in compose-spec/compose-spec#110 fixes docker#7919 closes docker#1896 closes docker#6742 closes docker#7539 Signed-off-by: Roman Anasal <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Introduce
profilesin compose schema and specification.This is based on the PR #98 by @ndeloof and the discussion in #97. It diverges from #98 by:
profiles#98 (comment))Automatically enabling the profiles of explicitly targeted service is the minimal amount of "magic" required here to allow for a sane UX when targeting services with dependencies in non-default profiles. But at the same time it still forces the users to specify a valid compose model where all dependencies share a common profile.
Which issue(s) this PR fixes:
Fixes #97
see also #98
Fixes #87