de-deprecate runtime#102
Merged
ndeloof merged 1 commit intocompose-spec:masterfrom Jan 27, 2021
Merged
Conversation
This was referenced Sep 14, 2020
Closed
ndeloof
reviewed
Sep 18, 2020
| ### runtime | ||
| _DEPRECATED: this attribute is low-level platform implementation detail_ | ||
|
|
||
| `runtime` specifies which runtime to use for the service’s containers. |
Collaborator
There was a problem hiding this comment.
if we embrace this attribute, should then be correctly documented.
Can you at least include a link to https://github.com/opencontainers/runtime-spec/blob/master/implementations.md ?
Contributor
Author
There was a problem hiding this comment.
updated, sorry for the delay
This field was ported from v2 and marked as deprecated in compose-spec#78, but still useful for Kata and gVisor users. Close compose-spec#101 Signed-off-by: Akihiro Suda <[email protected]>
AkihiroSuda
force-pushed
the
de-deprecate-runtime
branch
from
b97e12e to
995818e
Compare
ndeloof
approved these changes
Jan 11, 2021
EricHripko
approved these changes
Jan 15, 2021
Collaborator
EricHripko
left a comment
EricHripko
left a comment
There was a problem hiding this comment.
Looks good to me ✅ Thanks again for this contribution 🙌
Contributor
Author
|
Is this ready to merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
De-deprecate
runtime.This field was ported from v2 and marked as deprecated in #78, but still useful for Kata and gVisor users.
Which issue(s) this PR fixes:
Fixes #101