Skip to content

WithDefaultProfiles must read COMPOSE_PROFILES from project.Environment#632

Merged
ndeloof merged 1 commit intocompose-spec:mainfrom
ndeloof:WithDefaultProfiles
May 30, 2024
Merged

WithDefaultProfiles must read COMPOSE_PROFILES from project.Environment#632
ndeloof merged 1 commit intocompose-spec:mainfrom
ndeloof:WithDefaultProfiles

Conversation

@ndeloof
Copy link
Copy Markdown
Collaborator

@ndeloof ndeloof commented May 29, 2024

must not use os.Getenv as some earlier loader options (WithDotEnv) do parse env file which also can define COMPOSE_PROFILES

fixes docker/compose#11856

Copy link
Copy Markdown
Collaborator

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndeloof ndeloof merged commit 7dfa54c into compose-spec:main May 30, 2024
@ndeloof ndeloof deleted the WithDefaultProfiles branch May 30, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] COMPOSE_PROFILES ignored from --env-file in v2.27.1?

2 participants