always use values from lookup function if available#266
Merged
Conversation
ndeloof
approved these changes
May 30, 2022
glours
force-pushed
the
env-var-priority
branch
2 times, most recently
from
08acaac to
a4f05be
Compare
Signed-off-by: Guillaume Lours <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a simple workaround to fix an existing issue with env variables not taking precedence to env file values
We definitely should take time to refactor the parsing and interpolating process to strictly follow the rules defines in the compose doc
I think, we also need to make those rules clear in the Compose Specification, WDYT? @ulyssessouza @ndeloof
Signed-off-by: Guillaume Lours [email protected]