Pass onTextLayout to BasicText#185
Merged
alexstyl merged 2 commits intocomposablehorizons:mainfrom Jan 2, 2026
Merged
Conversation
alexstyl
requested changes
Dec 31, 2025
Member
alexstyl
left a comment
alexstyl
left a comment
There was a problem hiding this comment.
Let's move the parameter to be not the last parameter. Trailing lambdas are for content parameters.
Other than that it looks good
alexstyl
approved these changes
Jan 2, 2026
Member
|
LGTM. Let's merge this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added onTextLayout callback parameter to the Text composable.
This callback returns information after the layout is calculated. For example, it helps detect overflow and track other changes.
BasicText supports this parameter, but it hasn't been exposed for the higher-level Text.