Repository navigation
fix(compiler): disable color decorators for assembly output - #9105
Merged
mattgodbolt merged 1 commit intoSep 14, 2026
Merged
mattgodbolt merged 1 commit into
mattgodbolt merged 1 commit into
Conversation
Member
|
lol! Thanks for this :) I didn't know it was so easy to fix :) |
|
This is now live |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #9080. The compiler output pane uses Monaco's default color decorators, so assembly constants such as
#308and#8are shown with misleading color selector squares in Arm/AArch64 output.Root cause and solution
Monaco enables
colorDecoratorsby default. The read-only assembly output editor did not override that general-purpose editor setting. The compiler output configuration now disables color decorators for theasmeditor only.Tests
make checknpm run check-frontend-importsnpm run check-license-headersnpm run webpackThe focused frontend regression test verifies the exact editor options passed by
Compiler.createEditor(). All checks passed; webpack retained only the repository's existing CSS-order and asset-size warnings.The change is limited to the compiler output pane and does not affect source editors or other Monaco panes.