Skip to content

Commit 147f3f4

Browse files
docs: point N1 at T1 for not-a-fallback and at N5 for Spark
A dry run rewrote "falls back to its native execution" and "executes natively (not falling back to Spark)" wrongly, because N1 offered only T1 or T3. N1 now says not falling back is T1, since codegen dispatch is not a fallback, and that Spark's own behavior is N5. Generated-by: OpenCode
1 parent e8b8000 commit 147f3f4

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

‎docs/source/contributor-guide/style_guide.md‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,9 @@ is meant. Name the meaning instead.
8686
- **N1.** Do not use _runs natively_, _natively in Comet_, _the native path_, _the native
8787
pipeline_, _native execution_, _native operator_, or _native Comet operator_, in any tense or
8888
form, such as _ran natively_, _go native_, _a native path_, or _Comet-native_. Write _in the Comet
89-
pipeline_ (T1) or _Rust-implemented_ (T3).
89+
pipeline_ (T1) or _Rust-implemented_ (T3). When "native" means "did not fall back to Spark", write
90+
T1, because codegen dispatch (T5) is not a fallback. When the sentence is about Spark's own
91+
behavior, N5 applies.
9092
- **N2.** These compounds are allowed everywhere, because the second part fixes the meaning:
9193
_native Rust_; _native shuffle_ and _the native shuffle path_ (the counterpart of _JVM shuffle_,
9294
which need not appear beside it); "native", optionally followed by a format, followed by _scan_,

0 commit comments

Comments
 (0)