Skip to content

Commit 3e6058d

Browse files
authored
chore: skip slow test under force_hash_collisions (apache#26594)
## Which issue does this PR close? - Addresses an issue introduced in apache#25820 - Related to apache#25088, apache#25148 ## Rationale for this change apache#25820 added a test, `sort_after_group_by_reserves_shared_output_once`, which takes ~17 minutes when run under `force_hash_collisions`. This increased the runtime of the extended "hash collisions" job from 3-5 minutes to ~20 minutes, which slows down the merge queue and consumes CI resources. This PR disables the test under `force_collisions` mode. ## What changes are included in this PR? See above. ## What is the testing strategy for this PR? Test config change only. ## Are there any user-facing changes? No.
1 parent 290e263 commit 3e6058d

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

  • datafusion/core/tests/memory_limit

‎datafusion/core/tests/memory_limit/mod.rs‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -453,6 +453,10 @@ async fn group_by_count_distinct_utf8_view() {
453453
/// the buffered slices are sorted: coalesced into runs for a single sort key,
454454
/// and one run per slice otherwise. The in-place threshold is below the slice
455455
/// size, so that coalescing keeps the slices as separate runs.
456+
///
457+
/// Skipped under `force_hash_collisions`, where the 100,000 colliding group
458+
/// keys make the aggregate quadratic and the test take many minutes.
459+
#[cfg(not(feature = "force_hash_collisions"))]
456460
#[tokio::test]
457461
async fn sort_after_group_by_reserves_shared_output_once() {
458462
for order_by in ["group_key", "s desc, group_key"] {

0 commit comments

Comments
 (0)